set default value of mlp_impl to grouped in layers/arguments #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets the default value of
mlp_impl
togrouped
inmegablocks/layers/arguments/Arguments
dataclass.This is done to avoid the default dmoe script in
exp/dmoe/dmoe_46m_8gpu.sh
to crash with:What issue(s) does this change relate to?
Fixes #170
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)