Skip to content

chore: Add static optimizer with seperated method.#346

Closed
He-Pin wants to merge 1 commit intodatabricks:masterfrom
He-Pin:staticOpt
Closed

chore: Add static optimizer with seperated method.#346
He-Pin wants to merge 1 commit intodatabricks:masterfrom
He-Pin:staticOpt

Conversation

@He-Pin
Copy link
Copy Markdown
Contributor

@He-Pin He-Pin commented Apr 29, 2025

Motivation:
Try to re-add #344 back.

@stephenamar-db , How about this one? I separate the code into dedicated methods.

@stephenamar-db stephenamar-db self-requested a review April 29, 2025 06:21
@stephenamar-db
Copy link
Copy Markdown
Collaborator

I need more time to look.
Removing all remaining static optimizations for booleans actually improves performance. There's something going on that I don't get.

@He-Pin
Copy link
Copy Markdown
Contributor Author

He-Pin commented Apr 29, 2025

@stephenamar-db I'm fine, our use case is the scripts are been parsed and we will use them several times, as the current parse caches are separated for script and extVar and tlaVar, so it would be better to cache a parsed and optimized scripts' AST.

Another thing is if the tableSwitch did not affect the performance, we can make use of it to do a quick O(1) jump, my current work is not been blocked by any of this, let's take it easy, thank you.

@He-Pin He-Pin marked this pull request as draft May 13, 2025 05:57
@He-Pin He-Pin closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants