Revert last changes that caused performance regressions#351
Merged
stephenamar-db merged 2 commits intomasterfrom Apr 29, 2025
Merged
Revert last changes that caused performance regressions#351stephenamar-db merged 2 commits intomasterfrom
stephenamar-db merged 2 commits intomasterfrom
Conversation
This reverts commit 0d9e479.
Collaborator
Author
9ebde1f to
8cfa660
Compare
Contributor
|
Wired, The lazy val will access the barrier |
Contributor
|
If that's the lazy val bootst the performance, please add an comments. |
Contributor
|
If this could work, then a var evaluater and evaluater() method to get or create will works too , and avoid the double check, wired any way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why the
Make evalutator a simple valmade a difference, but it did.We are back to the performance level of the scala3 migration (which is better than the 0.4 series)