Skip to content

chore: bump mill 0.12.14#397

Merged
stephenamar-db merged 1 commit intodatabricks:masterfrom
He-Pin:bumpMill
May 20, 2025
Merged

chore: bump mill 0.12.14#397
stephenamar-db merged 1 commit intodatabricks:masterfrom
He-Pin:bumpMill

Conversation

@He-Pin
Copy link
Copy Markdown
Contributor

@He-Pin He-Pin commented May 17, 2025

Motivation:

  1. Bump mill to 0.12.14
  2. Add windows mill.bat

@He-Pin He-Pin marked this pull request as draft May 17, 2025 05:22
@He-Pin He-Pin marked this pull request as ready for review May 17, 2025 07:11
// test("comments") {
// eval(nontrivial / "mixins.jsonnet", comments = true) ==>
// os.read(nontrivial / "mixins.golden.comments.yaml")
// }
Copy link
Copy Markdown
Contributor Author

@He-Pin He-Pin May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is an issue in mill's scala native support here, which fails because of the path is in the sandbox, but the JVM and js is OK.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look

@He-Pin He-Pin changed the title chore: bump mill 0.12.11 chore: bump mill 0.12.13 May 18, 2025
@He-Pin
Copy link
Copy Markdown
Contributor Author

He-Pin commented May 19, 2025

@stephenamar-db I would like to see this get merged first, because it seems fix some problems when I do packaging it locally.

@stephenamar-db
Copy link
Copy Markdown
Collaborator

sync and I'll merge

@He-Pin He-Pin changed the title chore: bump mill 0.12.13 chore: bump mill 0.12.14 May 20, 2025
@stephenamar-db stephenamar-db merged commit 8e980ba into databricks:master May 20, 2025
6 checks passed
@He-Pin He-Pin deleted the bumpMill branch May 21, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants