Skip to content

feat(jvm,native): Special-case "/dev/stdin" and "-" in TLAs, extVars, top-level file. - #449

Merged
stephenamar-db merged 1 commit into
databricks:masterfrom
rudo-thomas:rudo-thomas/specialcase-/dev/null
Jun 27, 2025
Merged

feat(jvm,native): Special-case "/dev/stdin" and "-" in TLAs, extVars, top-level file.#449
stephenamar-db merged 1 commit into
databricks:masterfrom
rudo-thomas:rudo-thomas/specialcase-/dev/null

Conversation

@rudo-thomas

@rudo-thomas rudo-thomas commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

See #448.

The /dev/stdin case is a work-around until
scala-native/scala-native#4384 is fixed.

Comment thread sjsonnet/src-jvm-native/sjsonnet/SjsonnetMainBase.scala Outdated
@stephenamar-db

Copy link
Copy Markdown
Collaborator

Maybe move this change to the native Main only. if JVM is fine with /dev/stdin, let's not make the change for it.

I'm also 100% for adding support for "-"

@rudo-thomas
rudo-thomas force-pushed the rudo-thomas/specialcase-/dev/null branch from eb86b02 to 7f11e3a Compare June 27, 2025 11:14
@rudo-thomas rudo-thomas changed the title feat(jvm,native): Special-case "/dev/stdin" in TLAs, extVars, top-level file. feat(jvm,native): Special-case "/dev/stdin" and "-" in TLAs, extVars, top-level file. Jun 27, 2025
@rudo-thomas

Copy link
Copy Markdown
Contributor Author

Rebased. Also:

  • added TODO with a link to the scala-native bug
  • special case "-" everywhere

Moving the /dev/stdin case to native Main only would require quite a refactor, so I'm hoping this is fine as is -- with the expectation it will go away when scala-native is fixed.

… top-level file.

See databricks#448.

The /dev/stdin case is a work-around until
scala-native/scala-native#4384 is fixed.
@rudo-thomas
rudo-thomas force-pushed the rudo-thomas/specialcase-/dev/null branch from 7f11e3a to 8d7d4ac Compare June 27, 2025 11:20
@stephenamar-db
stephenamar-db merged commit bb63ee6 into databricks:master Jun 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants