Skip to content

Conversation

@sundarshankar89
Copy link
Collaborator

@sundarshankar89 sundarshankar89 commented Sep 22, 2025

  • Adds support for correct serialization and deserialization of bool type fields in dataclass objects. This ensures that boolean fields with a value of False are properly handled and not skipped during serialization.

@github-actions
Copy link

github-actions bot commented Sep 22, 2025

✅ 40/40 passed, 2 skipped, 1m42s total

Running from acceptance #361

@sundarshankar89 sundarshankar89 self-assigned this Sep 22, 2025
@sundarshankar89 sundarshankar89 changed the base branch from main to patch/fix_hatch_click_ci September 22, 2025 06:18
@sundarshankar89 sundarshankar89 added stacked-pr bug Something isn't working labels Sep 22, 2025
Base automatically changed from patch/fix_hatch_click_ci to main September 22, 2025 06:31
Comment on lines 770 to 771
__version__ = 3
skip_validation: bool = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also check the False case?

Copy link
Collaborator Author

@sundarshankar89 sundarshankar89 Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, I added another example in the same tests.

Or do you want to default to be False ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I wanted was both values to be checked, just to shake out any issues with 'truthy' logic that might be present elsewhere.

(The area of logic modified by this PR contains lots of checks for different things, and in some ways they're co-dependent: an early branch means that later branches might not be reached when they should.)

Comment on lines 770 to 771
__version__ = 3
skip_validation: bool = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I wanted was both values to be checked, just to shake out any issues with 'truthy' logic that might be present elsewhere.

(The area of logic modified by this PR contains lots of checks for different things, and in some ways they're co-dependent: an early branch means that later branches might not be reached when they should.)

Comment on lines 771 to 772
skip_validation: bool = True
sdk_config: JsonValue = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits:

  • Drop the default values.
  • I don't understand the meaning of MissingAttribute in the name. Maybe BooleanAttributeClass.
  • Maybe kw_only=True (useful for boolean and integer properties on data classes).

What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@asnare asnare removed the request for review from nfx September 23, 2025 07:56
Copy link
Contributor

@asnare asnare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we can't merge or release with those downstream UCX failures… do you understand why they're happening?

@sundarshankar89
Copy link
Collaborator Author

@asnare
WorkspaceConfig in ucx config has is_terraform_used because of the earlier bug, this was not caught
I believe this requires updating the tests in UCX?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants