-
Notifications
You must be signed in to change notification settings - Fork 12
Add Support for bool type fields serialization and deserialization #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ 40/40 passed, 2 skipped, 1m42s total Running from acceptance #361 |
tests/unit/test_installation.py
Outdated
| __version__ = 3 | ||
| skip_validation: bool = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also check the False case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, I added another example in the same tests.
Or do you want to default to be False ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All I wanted was both values to be checked, just to shake out any issues with 'truthy' logic that might be present elsewhere.
(The area of logic modified by this PR contains lots of checks for different things, and in some ways they're co-dependent: an early branch means that later branches might not be reached when they should.)
tests/unit/test_installation.py
Outdated
| __version__ = 3 | ||
| skip_validation: bool = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All I wanted was both values to be checked, just to shake out any issues with 'truthy' logic that might be present elsewhere.
(The area of logic modified by this PR contains lots of checks for different things, and in some ways they're co-dependent: an early branch means that later branches might not be reached when they should.)
tests/unit/test_installation.py
Outdated
| skip_validation: bool = True | ||
| sdk_config: JsonValue = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits:
- Drop the default values.
- I don't understand the meaning of
MissingAttributein the name. MaybeBooleanAttributeClass. - Maybe
kw_only=True(useful for boolean and integer properties on data classes).
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we can't merge or release with those downstream UCX failures… do you understand why they're happening?
|
@asnare |
Uh oh!
There was an error while loading. Please reload this page.