Added Databricks CLI & Azure CLI authentication and a basic integration test #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacdav-db
reviewed
Mar 27, 2024
| if (!is_azure()) { | ||
| return(NULL) | ||
| } | ||
| token_source <- .azure_cli_token_source("2ff814a6-3304-4ab8-85cb-cd0e6f879c1d") |
There was a problem hiding this comment.
Nope. It holds private state used for token refreshing internally when it's about to expire
zacdav-db
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Need to fix is_<cloud> functions to handle NULL:
databricks-sdk-r/R/api_client.R
Lines 123 to 135 in bb96aac
e.g.
is_azure <- function() {
if (!is.null(cfg$host)) {
grepl(".azuredatabricks.net", cfg$host)
} else {
FALSE
}
}There was a problem hiding this comment.
That's a bit irrelevant to this PR, can you please send one?
There was a problem hiding this comment.
also, in this case, we won't have null there, per se
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.