Eliminate Path(__file__) to locate resource files
#2210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for tests. This removes the need for `Path(__file__)`-based manipulation.
asnare
added
tech debt
|
✅ 129/129 passed, 7 flaky, 5 skipped, 19m12s total Flaky tests:
Running from acceptance #3443 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
=======================================
Coverage 64.05% 64.05%
=======================================
Files 100 100
Lines 8624 8625 +1
Branches 893 889 -4
=======================================
+ Hits 5524 5525 +1
Misses 2928 2928
Partials 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In addition, update tests: - No more Path(__file__) manipulation. - Test pipeline configurations now use paths relative to the test resources.
7 tasks
m-abulazm
requested changes
Jan 5, 2026
m-abulazm
approved these changes
Jan 8, 2026
| from ..conftest import FunctionalTestFile, FunctionalTestFileWithExpectedException, get_functional_test_files | ||
|
|
||
|
|
||
| def pytest_generate_tests(metafunc: pytest.Metafunc) -> None: |
Collaborator
There was a problem hiding this comment.
I see you moved test_databricks to test_snowflake
Contributor
Author
There was a problem hiding this comment.
Indeed, the pattern for the other ones is to name these after the source system. So the changes here are:
- The snowflake ones were moved from
test_databricks.pytotest_snowflake.py. - There were 2 sets of functional tests for each source system, in separate files: I've moved them into the same file.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
## Changes ### What does this PR do? This PR eliminates the use of `Path(__file__)` to locate file-based resources. In general: - In the main code, this is buggy: modern Python should use `importlib.resources` instead. - In tests, it's brittle and difficult to read because it's normally based on relative paths and traversal of many parent directories. It's also unnecessary, because pytest provides a mechanism for locating the project root. (Tests can also use `importlib.resources`, and probably should, but that's a bigger refactoring: this is a first step.) Some incidental changes that are introduced: - Type hints in a few places. - Functional tests against Snowflake, Oracle and Presto have been consolidated into a single module. (The Snowflake functional tests have been moved into `test_snowflake.py`: `test_databricks.py` was misleading.) - The `PipelineConfig` (and `Step`) classes have been made immutable. (An unnecessary `__post__init()` method has also been eliminated.) ### Tests - existing unit tests - existing integration tests
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
This PR eliminates the use of
Path(__file__)to locate file-based resources. In general:importlib.resourcesinstead.importlib.resources, and probably should, but that's a bigger refactoring: this is a first step.)Some incidental changes that are introduced:
test_snowflake.py:test_databricks.pywas misleading.)PipelineConfig(andStep) classes have been made immutable. (An unnecessary__post__init()method has also been eliminated.)Tests