-
Notifications
You must be signed in to change notification settings - Fork 83
Refactor recon intermediate persistence #2230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2230 +/- ##
==========================================
- Coverage 63.96% 63.91% -0.06%
==========================================
Files 99 99
Lines 8626 8634 +8
Branches 888 888
==========================================
Hits 5518 5518
- Misses 2936 2944 +8
Partials 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 132/132 passed, 9 flaky, 5 skipped, 14m21s total Flaky tests:
Running from acceptance #3462 |
b836136 to
91b1e98
Compare
f112109 to
fb290c2
Compare
| @cached_property | ||
| def _is_databricks(self) -> bool: | ||
| is_db = any(k.startswith("spark.databricks") for k in self._spark.conf.getAll.keys()) | ||
| logger.info(f"Running on Databricks check completed with result: {is_db}") | ||
| return is_db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would create this method outside the class.
| @cached_property | |
| def _is_databricks(self) -> bool: | |
| is_db = any(k.startswith("spark.databricks") for k in self._spark.conf.getAll.keys()) | |
| logger.info(f"Running on Databricks check completed with result: {is_db}") | |
| return is_db | |
| @lru_cache(maxsize=1) | |
| def is_databricks(spark: SparkSession) -> bool: | |
| is_db = any(k.startswith("spark.databricks") for k in spark.conf.getAll.keys()) | |
| logger.info(f"Running on Databricks check completed with result: {is_db}") | |
| return is_db |
Changes
What does this PR do?
overwritewrite modeCaveats/things to watch out for when reviewing:
On Serverless we cannot use cache/persist, so we use Delta writes acting as materialization boundaries
Linked issues
Resolves #1056
Advances #1905, #1438
Functionality
databricks labs lakebridge ...Tests