fix(registry): prefer configured registry volume over legacy session defaults - #122
Open
bcastelino wants to merge 1 commit into
Open
fix(registry): prefer configured registry volume over legacy session defaults#122bcastelino wants to merge 1 commit into
bcastelino wants to merge 1 commit into
Conversation
…defaults Registry config now treats env/settings values (catalog, schema, volume) as authoritative before falling back to legacy per-session Unity Catalog values when no bound Volume or Lakebase registry row is selected. Fixes local init selecting the legacy OntoBricksRegistry default despite REGISTRY_VOLUME=ontology.
bcastelino
force-pushed
the
fix/registry-config-precedence
branch
from
July 24, 2026 22:47
b593129 to
79c2920
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registry configuration resolution now treats environment/settings values (
registry_catalog,registry_schema,registry_volume) as authoritative in the last-resort fallback of RegistryCfg.from_domain, using legacy per-sessiondomain.settings["registry"]values only when the configured values are unset. Previously the order was inverted (reg.get(...) or settings...), so a stale session value could shadow the configured environment — local Registry init kept selecting the legacyOntoBricksRegistrydefault even withREGISTRY_VOLUME=ontologyloaded, causing binary-archive paths and Delta views to resolve against the wrong Volume when no bound Volume or Lakebase registry row was present.Linked Issue / milestone
N/A
Plan
N/A, single-file precedence fix with regression coverage.
Type of change
Author checklist
<type>(<scope>): <subject>).changelogs/<today>.logupdated with title + context + numbered changes + files + test result.uv run pytest tests/<scope>/green locally.pre-commit run --all-filesclean (or skipped hooks documented).src/agents/**or any MLflow-traced LLM path changed: N/A — no agent/LLM paths touched.src/mcp-server/**changed: N/A — no MCP changes.gsd-*references re-introduced.MLflow eval run
N/A, not an agent PR.
Test plan
python -m pytest tests/units/registry/test_registry.py -q --no-cov→ 55 passeduv run pytest tests/ -m "not e2e and not property and not eval" --cov-fail-under=90scripts/check_coverage.py) green for touched packages.Reviewer hint
Focus is the fallback
return cls(...)block in src/back/objects/registry/RegistryService.py (from_domain): the three fields now readsettings.* or reg.get(...)instead ofreg.get(...) or settings.*. Behaviour is unchanged when env/settings are empty. Regression coverage:tests/units/registry/test_registry.py::TestRegistryCfgFromDomain::test_settings_override_legacy_session_registry.