Skip to content

Conversation

@gueniai
Copy link
Collaborator

@gueniai gueniai commented Feb 20, 2025

  • Let make_serving_endpoint reference a valid model version (#106). The make_serving_endpoint fixture in the ml.py file has been updated to reference a valid model version, as the previous approach of using a model version of '1' no longer worked due to an issue with the make_model fixture. The updated fixture now falls back on a UC model version and allows users to provide input parameters to specify a different model or version. Optional parameters for the endpoint name, model name, and model version have been added, with default values set for each. Two new tests, test_make_serving_endpoint_no_args(), test_make_serving_endpoint_sets_default_model_version_to_one(), and test_make_serving_endpoint_sets_model_version(), have been included, with a call_context_setup parameter to modify the behavior of the Model Registry API for unit testing. The remove function has been updated to delete a specified endpoint, and a create function has been added to handle the creation of a Databricks Serving Endpoint, including creating a model to serve on a small workload size. This update addresses issues related to the missing model version in the make_model fixture and ensures that the make_serving_endpoint fixture can handle different scenarios and inputs for selecting a model version, providing a more robust and flexible testing experience.

* Let `make_serving_endpoint` reference a valid model version ([#106](#106)). The `make_serving_endpoint` fixture in the `ml.py` file has been updated to reference a valid model version, as the previous approach of using a model version of `'1'` no longer worked due to an issue with the `make_model` fixture. The updated fixture now falls back on a UC model version and allows users to provide input parameters to specify a different model or version. Optional parameters for the endpoint name, model name, and model version have been added, with default values set for each. Two new tests, `test_make_serving_endpoint_no_args()`, `test_make_serving_endpoint_sets_default_model_version_to_one()`, and `test_make_serving_endpoint_sets_model_version()`, have been included, with a `call_context_setup` parameter to modify the behavior of the Model Registry API for unit testing. The `remove` function has been updated to delete a specified endpoint, and a `create` function has been added to handle the creation of a Databricks Serving Endpoint, including creating a model to serve on a small workload size. This update addresses issues related to the missing model version in the `make_model` fixture and ensures that the `make_serving_endpoint` fixture can handle different scenarios and inputs for selecting a model version, providing a more robust and flexible testing experience.
@gueniai gueniai requested a review from nfx as a code owner February 20, 2025 19:27
@github-actions
Copy link

✅ 41/41 passed, 5 skipped, 22m5s total

Running from acceptance #186

@gueniai
Copy link
Collaborator Author

gueniai commented Feb 21, 2025

Closing because commits are not signed

@gueniai gueniai closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants