Set upper SDK limit to v1 #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
|
✅ 41/41 passed, 5 skipped, 15m6s total Running from acceptance #195 |
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
JCZuurmond
commented
Feb 21, 2025
| endpoint = ws.serving_endpoints.create( | ||
| endpoint_name, | ||
| EndpointCoreConfigInput(served_models=[served_model_input]), | ||
| config=EndpointCoreConfigInput(served_models=[served_model_input]), |
There was a problem hiding this comment.
Became a keyword argument in the latest sdk release: databricks/databricks-sdk-py@5339396#diff-5e9fe48f91fd6d3ad5a1266478600dde8698a2bba3c809367e560c7cef5f75caR3442-R3450
gueniai
temporarily deployed
to
account-admin
GitHub Actions
Inactive
gueniai
approved these changes
Feb 26, 2025
|
@gueniai : Could you bypass the CI, it fails on the downstream UCX, we can handle that separately |
gueniai
added a commit
that referenced
this pull request
Feb 27, 2025
* Set upper SDK limit to v1 ([#109](#109)). In this change, the upper SDK limit is set to version 1.0 in the pyproject.toml file of a library project, allowing projects using this library to set their own appropriate SDK limits. The databricks-sdk dependency is updated from "<0.42" to "<1.0" as a result of this commit. Additionally, the `create` function in the `ml.py` file of the pytester library has been modified. Previously, the `EndpointCoreConfigInput` object was passed as an argument to the `serving_endpoints.create` method using the keyword argument `served_models`. Now, `EndpointCoreConfigInput` is passed as a keyword argument `config`, which contains the `served_models` parameter, aligning with the new SDK version 1.0 and ensuring consistent endpoint creation. These changes are intended to ensure compatibility with a variety of SDK versions and improve the library's usability for software engineers.
Merged
gueniai
added a commit
that referenced
this pull request
Feb 27, 2025
* Set upper SDK limit to v1 ([#109](#109)). In this change, the upper SDK limit is set to version 1.0 in the pyproject.toml file of a library project, allowing projects using this library to set their own appropriate SDK limits. The databricks-sdk dependency is updated from "<0.42" to "<1.0" as a result of this commit. Additionally, the `create` function in the `ml.py` file of the pytester library has been modified. Previously, the `EndpointCoreConfigInput` object was passed as an argument to the `serving_endpoints.create` method using the keyword argument `served_models`. Now, `EndpointCoreConfigInput` is passed as a keyword argument `config`, which contains the `served_models` parameter, aligning with the new SDK version 1.0 and ensuring consistent endpoint creation. These changes are intended to ensure compatibility with a variety of SDK versions and improve the library's usability for software engineers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set upper SDK limit to 1.0 as this is a library and the projects using pytester should set the right SDK limit