Skip to content

Conversation

@gueniai
Copy link
Collaborator

@gueniai gueniai commented Feb 21, 2025

  • Let make_serving_endpoint reference a valid model version (#106). The make_serving_endpoint fixture in the ml.py file has been updated to resolve an issue where it stopped working due to the removal of the default model version from models created by the make_model fixture. The updated fixture now fallbacks to using a UC model version and allows users to input parameters for choosing another model version or name. The fixture now accepts optional keyword arguments endpoint_name, model_name, and model_version. The create function of the fixture has also been updated to include a RemoveAfter tag and to accept a ServingEndpointDetailed object in the remove function instead of just an endpoint name. Unit tests have been added to ensure the functionality works as expected and cover various scenarios such as default endpoint name, setting endpoint name, default model name, setting model name, and setting model version. The call_stateful function has also been updated to include CallContext in its signature.

* Let `make_serving_endpoint` reference a valid model version ([#106](#106)). The `make_serving_endpoint` fixture in the `ml.py` file has been updated to resolve an issue where it stopped working due to the removal of the default model version from models created by the `make_model` fixture. The updated fixture now fallbacks to using a UC model version and allows users to input parameters for choosing another model version or name. The fixture now accepts optional keyword arguments `endpoint_name`, `model_name`, and `model_version`. The `create` function of the fixture has also been updated to include a `RemoveAfter` tag and to accept a `ServingEndpointDetailed` object in the `remove` function instead of just an endpoint name. Unit tests have been added to ensure the functionality works as expected and cover various scenarios such as default endpoint name, setting endpoint name, default model name, setting model name, and setting model version. The `call_stateful` function has also been updated to include `CallContext` in its signature.
@gueniai gueniai requested a review from nfx as a code owner February 21, 2025 19:03
@github-actions
Copy link

✅ 41/41 passed, 5 skipped, 5m52s total

Running from acceptance #192

@gueniai gueniai closed this Feb 24, 2025
@gueniai gueniai deleted the prepare/0.7.0 branch February 24, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants