Skip to content

Conversation

@gueniai
Copy link
Collaborator

@gueniai gueniai commented Feb 24, 2025

  • Let make_serving_endpoint reference a valid model version (#106). In this release, the make_serving_endpoint fixture has been updated to enhance its functionality and flexibility. The fixture now accepts optional keyword arguments for specifying the endpoint name, model name, and model version, with the model version defaulting to 1 and the latest version automatically retrieved for workspace local models. The served model input is created with the specified model name, model version, and workload size, and a mock endpoint object is returned if obtaining the served model fails. The remove method has been updated to accept a ServingEndpointDetailed object for deletion, and the fixture now maintains a logger instance for warning messages during model version retrieval. Unit tests have been added to ensure the changes work as expected, although integration tests have not been fixed yet. These updates address issues arising from changes in the make_model fixture and improve the robustness and flexibility of the make_serving_endpoint fixture.

* Let `make_serving_endpoint` reference a valid model version ([#106](#106)). In this release, the `make_serving_endpoint` fixture has been updated to enhance its functionality and flexibility. The fixture now accepts optional keyword arguments for specifying the endpoint name, model name, and model version, with the model version defaulting to `1` and the latest version automatically retrieved for workspace local models. The served model input is created with the specified model name, model version, and workload size, and a mock endpoint object is returned if obtaining the served model fails. The `remove` method has been updated to accept a `ServingEndpointDetailed` object for deletion, and the fixture now maintains a logger instance for warning messages during model version retrieval. Unit tests have been added to ensure the changes work as expected, although integration tests have not been fixed yet. These updates address issues arising from changes in the `make_model` fixture and improve the robustness and flexibility of the `make_serving_endpoint` fixture.
@gueniai gueniai requested a review from nfx as a code owner February 24, 2025 21:03
@github-actions
Copy link

✅ 41/41 passed, 5 skipped, 11m35s total

Running from acceptance #193

@gueniai gueniai merged commit cd6ea31 into main Feb 24, 2025
7 checks passed
@gueniai gueniai deleted the prepare/0.7.0 branch February 24, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants