-
Notifications
You must be signed in to change notification settings - Fork 10
Compatibility fix for Databricks SDK 0.51 #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of the SDK was released with a breaking change: an enumeration was removed, with a set of documented strings expected instead.
4 tasks
|
✅ 41/41 passed, 5 skipped, 8m32s total Running from acceptance #200 |
sundarshankar89
approved these changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sundarshankar89
added a commit
that referenced
this pull request
May 13, 2025
* Compatibility fix for Databricks SDK 0.51 ([#158](#158)). The minimum required version of the Databricks SDK has been updated to 0.51.0 to accommodate breaking changes introduced in this version, including the removal of certain enumeration values. Notably, the `ServedModelInputWorkloadSize` enumeration has been replaced with well-known string constants, prompting an update to the `create` function to use the string constant `Small` instead of the removed `ServedModelInputWorkloadSize.SMALL` value. This change affects the creation of serving endpoints, which now specify workload size using a string value, and resolves issues reported in related projects, including test failures in downstream projects, by ensuring compatibility with the updated SDK version.
Merged
sundarshankar89
added a commit
that referenced
this pull request
May 13, 2025
* Compatibility fix for Databricks SDK 0.51 ([#158](#158)). The minimum required version of the Databricks SDK has been updated to 0.51.0 to accommodate breaking changes introduced in this version, including the removal of certain enumeration values. Notably, the `ServedModelInputWorkloadSize` enumeration has been replaced with well-known string constants, prompting an update to the `create` function to use the string constant `Small` instead of the removed `ServedModelInputWorkloadSize.SMALL` value. This change affects the creation of serving endpoints, which now specify workload size using a string value, and resolves issues reported in related projects, including test failures in downstream projects, by ensuring compatibility with the updated SDK version.
This was
linked to
issues
May 14, 2025
Closed
This was
unlinked from
issues
May 14, 2025
Closed
This was
unlinked from
issues
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Databricks SDK 0.51 included some breaking changes, including removal of an enumeration where a set of well-known string constants must now be used instead:
The change is not forward-compatible, so in addition to updating the fixture we need to bump the minimum-required SDK version because older versions expect the enum.
Credits
This was earlier discovered and reported by @cornzyblack as #156.
Linked issues
Resolves #156.
Supersedes #157.
This is also causing CI test failures on downstream projects including:
Tests