Increased the number of random characters used when creating resources to minimize collisions #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwojtyczka
temporarily deployed
to
account-admin
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR increases the length of random identifiers used in test resource names from 4 to 8 characters to reduce naming collisions when running tests in parallel. This change addresses resource name clashes encountered in larger projects using pytester extensively.
- Increases random identifier length from 4 to 8 characters across all test fixtures
- Affects resource naming for workspace objects, secrets, queries, ML components, IAM resources, compute resources, and catalog objects
- Maintains existing naming patterns while reducing collision probability
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/databricks/labs/pytester/fixtures/workspace.py | Updates random ID length for notebook, file, directory, and repo creation |
| src/databricks/labs/pytester/fixtures/secrets.py | Updates random ID length for secret scope names |
| src/databricks/labs/pytester/fixtures/redash.py | Updates random ID length for query names |
| src/databricks/labs/pytester/fixtures/ml.py | Updates random ID length for ML experiments, models, and serving endpoints |
| src/databricks/labs/pytester/fixtures/iam.py | Updates random ID length for user and group names |
| src/databricks/labs/pytester/fixtures/compute.py | Updates random ID length for cluster policies, clusters, instance pools, jobs, pipelines, and warehouses |
| src/databricks/labs/pytester/fixtures/catalog.py | Updates random ID length for catalog, schema, table, function, and volume names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
✅ 40/40 passed, 6 skipped, 5m27s total Running from acceptance #220 |
mwojtyczka
temporarily deployed
to
account-admin
GitHub Actions
Inactive
mwojtyczka
temporarily deployed
to
account-admin
GitHub Actions
Inactive
mwojtyczka
changed the title
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alexott
approved these changes
Oct 17, 2025
sundarshankar89
added a commit
that referenced
this pull request
Oct 17, 2025
* Increased the number of random characters used when creating resources to minimize collisions ([#214](#214)). The library has been updated to increase the number of random characters used when creating resources from 4 to 8, minimizing collisions in larger projects that heavily rely on PyTester. This change affects various resource creation methods, including the generation of names for tables, schemas, catalogs, functions, storage credentials, volumes, users, groups, experiments, models, endpoints, and queries. The `make_random` function is now called with an argument of 8 to generate longer and more unique identifiers. Additionally, the hatch version has been updated from 1.9.4 to 1.15.0 to avoid compatibility issues with click. These changes are covered by regression testing and have been manually tested to ensure their effectiveness in reducing the frequency of collisions and improving the overall stability of the system.
sundarshankar89
added a commit
that referenced
this pull request
Oct 17, 2025
* Increased the number of random characters used when creating resources to minimize collisions ([#214](#214)). The continuous integration workflow has been updated to install a newer version of the hatch tool, specifically version 1.15.0, replacing the previous version 1.9.4, to avoid compatibility issues with click. Additionally, the code has been modified to increase the number of random characters used when creating resources from 4 to 8, aiming to minimize collisions, particularly in larger projects that rely heavily on PyTester. This change affects various resource creation methods and is intended to reduce the likelihood of name collisions and improve the overall stability of the system. The changes are covered by regression testing and have been manually tested to ensure their correctness and effectiveness.
Merged
mwojtyczka
pushed a commit
that referenced
this pull request
Oct 17, 2025
* Increased the number of random characters used when creating resources to minimize collisions ([#214](#214)). The continuous integration workflow has been updated to install a newer version of the hatch tool, specifically version 1.15.0, replacing the previous version 1.9.4, to avoid compatibility issues with click. Additionally, the code has been modified to increase the number of random characters used when creating resources from 4 to 8, aiming to minimize collisions, particularly in larger projects that rely heavily on PyTester. This change affects various resource creation methods and is intended to reduce the likelihood of name collisions and improve the overall stability of the system. The changes are covered by regression testing and have been manually tested to ensure their correctness and effectiveness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Changes covered by regression testing.