Support providing name in make_catalog fixture
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
JCZuurmond
commented
Sep 23, 2024
|
This PR breaks backwards compatibility for databrickslabs/blueprint downstream. See build logs for more details. Running from downstreams #38 |
|
✅ 35/35 passed, 3 skipped, 1m49s total Running from acceptance #79 |
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
5 tasks
asnare
requested changes
Sep 23, 2024
|
|
||
| def create() -> CatalogInfo: | ||
| name = f"dummy_C{make_random(4)}".lower() | ||
| def create(name: str = "") -> CatalogInfo: |
There was a problem hiding this comment.
The convention for create() methods is:
- Keyword-only arguments.
- A default of
Noneif they're optional. catalog_nameinstead ofname(for better composability).
The argument also needs to be described in the docstring for make_catalog above to ensure that it ends up in the project documentation.
There was a problem hiding this comment.
name -> catalog_name is not similar to make_schema
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
asnare
reviewed
Sep 23, 2024
JCZuurmond
force-pushed
the
feature/add-name-to-make-catalog
branch
from
4e42570 to
600ad0c
Compare
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
nfx
added a commit
that referenced
this pull request
Sep 23, 2024
* Support providing name in `make_catalog` fixture ([#52](#52)). The `make_catalog` fixture in our open-source library has been updated to allow users to specify a name for the catalog using a new `name` parameter. Previously, the catalog was given a random name, but now users can have more control and customization over catalog names in their tests. This change includes updates to the docstring and the addition of unit tests to ensure the fixture behaves as expected with the new parameter. Additionally, the underlying `call_stateful` function was updated to expect a callable that returns a generator of callables, enabling the support for providing a name. The `test_make_catalog_creates_catalog_with_name` and `test_make_catalog` tests have been added to verify the behavior of the fixture with the new `name` parameter.
Merged
nfx
added a commit
that referenced
this pull request
Sep 23, 2024
* Support providing name in `make_catalog` fixture ([#52](#52)). The `make_catalog` fixture in our open-source library has been updated to allow users to specify a name for the catalog using a new `name` parameter. Previously, the catalog was given a random name, but now users can have more control and customization over catalog names in their tests. This change includes updates to the docstring and the addition of unit tests to ensure the fixture behaves as expected with the new parameter. Additionally, the underlying `call_stateful` function was updated to expect a callable that returns a generator of callables, enabling the support for providing a name. The `test_make_catalog_creates_catalog_with_name` and `test_make_catalog` tests have been added to verify the behavior of the fixture with the new `name` parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add name parameter to
make_catalogfixture.Tests