Skip to content

Conversation

@nfx
Copy link
Collaborator

@nfx nfx commented Sep 24, 2024

  • Fixed PyPI metadata (#54). In this commit, the PyPI metadata for the pytester project has been updated with the new repository location at https://github.com/databrickslabs/pytester. The URLs for issues and source have been changed to point to the new repository, with the issues URL now directing to https://github.com/databrickslabs/pytester/issues and the source URL to https://github.com/databrickslabs/pytester. Furthermore, the versioning tool hatch has been configured to manage the version number in the "src/databricks/labs/pytester/about.py" file. This ensures accurate and consistent versioning for the pytester project moving forward.
  • Improve make_group/make_acc_group fixture consistency (#50). This PR introduces improvements to the make_group and make_acc_group fixtures, designed for managing Databricks workspace groups. The enhancements include a double-check approach to ensure group visibility by requiring the group to be retrievable via both .get() and .list() calls. This mitigates, but does not entirely eliminate, consistency issues with the APIs used for managing groups. The wait_for_provisioning argument has been removed and replaced with an internal wait mechanism. The argument is still accepted but triggers a deprecation warning. Internal unit-test plumbing has been updated to use mock fixtures tailored for each test, ensuring double-check implementation testability. New and updated unit tests are included in the test_iam.py file, along with the introduction of the _setup_groups_api function, which mocks specific clients to ensure group visibility when created. These changes improve consistency and reliability when working with Databricks workspace groups, making it easier for users to adopt the project.

* Fixed PyPI metadata ([#54](#54)). In this commit, the PyPI metadata for the pytester project has been updated with the new repository location at <https://github.com/databrickslabs/pytester>. The URLs for issues and source have been changed to point to the new repository, with the `issues` URL now directing to <https://github.com/databrickslabs/pytester/issues> and the `source` URL to <https://github.com/databrickslabs/pytester>. Furthermore, the versioning tool `hatch` has been configured to manage the version number in the "src/databricks/labs/pytester/__about__.py" file. This ensures accurate and consistent versioning for the pytester project moving forward.
* Improve `make_group`/`make_acc_group` fixture consistency ([#50](#50)). This PR introduces improvements to the `make_group` and `make_acc_group` fixtures, designed for managing Databricks workspace groups. The enhancements include a double-check approach to ensure group visibility by requiring the group to be retrievable via both `.get()` and `.list()` calls. This mitigates, but does not entirely eliminate, consistency issues with the APIs used for managing groups. The `wait_for_provisioning` argument has been removed and replaced with an internal wait mechanism. The argument is still accepted but triggers a deprecation warning. Internal unit-test plumbing has been updated to use mock fixtures tailored for each test, ensuring double-check implementation testability. New and updated unit tests are included in the `test_iam.py` file, along with the introduction of the `_setup_groups_api` function, which mocks specific clients to ensure group visibility when created. These changes improve consistency and reliability when working with Databricks workspace groups, making it easier for users to adopt the project.
@nfx nfx merged commit 512c014 into main Sep 24, 2024
7 of 9 checks passed
@nfx nfx deleted the prepare/0.2.4 branch September 24, 2024 10:13
@github-actions
Copy link

This PR breaks backwards compatibility for databrickslabs/blueprint downstream. See build logs for more details.

Running from downstreams #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants