Skip to content

Conversation

@JCZuurmond
Copy link
Contributor

Changes

Add factory type hint to have the editor recognize the types while developing

@JCZuurmond JCZuurmond self-assigned this Oct 4, 2024
@JCZuurmond JCZuurmond requested a review from nfx as a code owner October 4, 2024 08:52
@github-actions
Copy link

github-actions bot commented Oct 4, 2024

This PR breaks backwards compatibility for databrickslabs/blueprint downstream. See build logs for more details.

Running from downstreams #56

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

This PR breaks backwards compatibility for databrickslabs/lsql downstream. See build logs for more details.

Running from downstreams #56

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

✅ 35/35 passed, 3 skipped, 2m32s total

Running from acceptance #97

@JCZuurmond JCZuurmond changed the title Add factory type hint [TECH DEBT] Add factory type hint Oct 4, 2024
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit 0975eb7 into main Oct 7, 2024
7 of 9 checks passed
@nfx nfx deleted the fix/factory-type-hint branch October 7, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants