Skip to content

Conversation

@HariGS-DB
Copy link
Contributor

@HariGS-DB HariGS-DB commented Oct 10, 2024

Changes

Added option to pass location field in make_schema fixture to create a managed schema

Resolves #65

Tests

  • added unit tests
  • added integration tests

@HariGS-DB HariGS-DB requested a review from nfx as a code owner October 10, 2024 20:03
@github-actions
Copy link

github-actions bot commented Oct 10, 2024

✅ 38/38 passed, 3 skipped, 8m12s total

Running from acceptance #113

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit dc0233f into main Oct 11, 2024
7 checks passed
@nfx nfx deleted the feat/managedschema branch October 11, 2024 11:27
nfx added a commit that referenced this pull request Oct 11, 2024
* Updated databrickslabs/sandbox requirement to acceptance/v0.3.1 ([#64](#64)). In this pull request, we are updating the requirement for the `databrickslabs/sandbox` package to version `acceptance/v0.3.1`. This update is necessary to resolve any conflicts and ensure compatibility with the latest version of the package. The update includes several bug fixes, dependency updates, and the addition of install instructions in the changelog. The package also includes new git-related libraries and modifications to the README to explain how to use the package with the `databricks labs sandbox` command. Additionally, there are dependency updates for `golang.org/x/crypto` in the `go-libs` and `runtime-packages` directories. Keeping dependencies up-to-date is important for taking advantage of new features and bug fixes, so it is recommended to merge this pull request and address any conflicts or issues that may arise. This update is generated by Dependabot, a tool used to keep dependencies up-to-date, and it will handle any conflicts as long as the pull request is not modified. The `databrickslabs/sandbox` package is used for building and testing the project.
* Updating `make_schema` fixture to include location to create managed schema ([#66](#66)). In this update, the `make_schema` fixture has been enhanced to include an optional `location` parameter, enabling users to specify the location for creating a managed schema. This change addresses issue [#6](#6)
* [chore] update acceptance.yml and remove circular downstreads. In this release, the `acceptance.yml` file in the `.github/workflows` directory has been updated to use the `acceptance/v0.3.1` Docker image for the `Run integration tests` job, replacing the previous `acceptance/v0.2.2` version. This change ensures that the latest version of the integration tests are being run, which may include bug fixes, new features, and other improvements. The `timeout` parameter has been removed from the job, which may result in longer test execution times but ensures that the tests have enough time to complete. Additionally, the `ARM_CLIENT_ID` and `GITHUB_TOKEN` secrets are now passed as environment variables to the job. The `downstreams.yml` file has also been updated to remove circular dependencies and streamline the build process, while maintaining the use of the `ubuntu-latest` runtime and `fail-fast` option. The `Run nightly tests` job has been updated to use the `acceptance/v0.3.1` Docker image, which may improve test execution during the nightly build due to potential bug fixes, new functionality, or better handling of timeout scenarios. The `create_issues` parameter remains set to true, ensuring that any test failures will result in the creation of GitHub issues to track them. These changes aim to improve the reliability and efficiency of the build and test processes.

Dependency updates:

 * Updated databrickslabs/sandbox requirement to acceptance/v0.3.1 ([#64](#64)).
@nfx nfx mentioned this pull request Oct 11, 2024
nfx added a commit that referenced this pull request Oct 11, 2024
* Updated databrickslabs/sandbox requirement to acceptance/v0.3.1
([#64](#64)). In this
pull request, we are updating the requirement for the
`databrickslabs/sandbox` package to version `acceptance/v0.3.1`. This
update is necessary to resolve any conflicts and ensure compatibility
with the latest version of the package. The update includes several bug
fixes, dependency updates, and the addition of install instructions in
the changelog. The package also includes new git-related libraries and
modifications to the README to explain how to use the package with the
`databricks labs sandbox` command. Additionally, there are dependency
updates for `golang.org/x/crypto` in the `go-libs` and
`runtime-packages` directories. Keeping dependencies up-to-date is
important for taking advantage of new features and bug fixes, so it is
recommended to merge this pull request and address any conflicts or
issues that may arise. This update is generated by Dependabot, a tool
used to keep dependencies up-to-date, and it will handle any conflicts
as long as the pull request is not modified. The
`databrickslabs/sandbox` package is used for building and testing the
project.
* Updating `make_schema` fixture to include location to create managed
schema ([#66](#66)). In
this update, the `make_schema` fixture has been enhanced to include an
optional `location` parameter, enabling users to specify the location
for creating a managed schema. This change addresses issue
[#6](#6)
* [chore] update acceptance.yml and remove circular downstreads. In this
release, the `acceptance.yml` file in the `.github/workflows` directory
has been updated to use the `acceptance/v0.3.1` Docker image for the
`Run integration tests` job, replacing the previous `acceptance/v0.2.2`
version. This change ensures that the latest version of the integration
tests are being run, which may include bug fixes, new features, and
other improvements. The `timeout` parameter has been removed from the
job, which may result in longer test execution times but ensures that
the tests have enough time to complete. Additionally, the
`ARM_CLIENT_ID` and `GITHUB_TOKEN` secrets are now passed as environment
variables to the job. The `downstreams.yml` file has also been updated
to remove circular dependencies and streamline the build process, while
maintaining the use of the `ubuntu-latest` runtime and `fail-fast`
option. The `Run nightly tests` job has been updated to use the
`acceptance/v0.3.1` Docker image, which may improve test execution
during the nightly build due to potential bug fixes, new functionality,
or better handling of timeout scenarios. The `create_issues` parameter
remains set to true, ensuring that any test failures will result in the
creation of GitHub issues to track them. These changes aim to improve
the reliability and efficiency of the build and test processes.

Dependency updates:

* Updated databrickslabs/sandbox requirement to acceptance/v0.3.1
([#64](#64)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to create a managed schema with location

3 participants