Skip to content

Conversation

@mwojtyczka
Copy link
Contributor

Changes

Linked issues

Resolves #..

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

@github-actions
Copy link

github-actions bot commented Jan 31, 2025

✅ 41/41 passed, 5 skipped, 7m28s total

Running from acceptance #179

@mwojtyczka mwojtyczka changed the title updated release pipeline Refactor integration test Feb 3, 2025
@mwojtyczka mwojtyczka requested review from JCZuurmond and removed request for nfx February 3, 2025 11:32
Copy link
Contributor

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_shared_cluster is only used by test_databricks_connect, it does not have a teardown and it is just one line, so maybe you can move it into the test. Approving so you can move forward

@mwojtyczka
Copy link
Contributor Author

mwojtyczka commented Feb 3, 2025

set_shared_cluster

Thank you!
We need to set the cluster before the ws fixture is created. Therefore a fixture is required here.
I added missing teardown.

@mwojtyczka mwojtyczka merged commit 0202115 into main Feb 3, 2025
7 checks passed
@mwojtyczka mwojtyczka deleted the shared_cluster branch February 3, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants