Skip to content

Conversation

@nitinaggarwal-databricks

Added the agent genie app source code

@github-actions
Copy link

All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@alexott alexott requested a review from Copilot September 16, 2025 14:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds the complete source code for an agent genie application, implementing a FastAPI-based Databricks Genie++ Omni-Analytics Platform. The application provides a conversational interface for data analytics, supporting features like PDF document analysis, user interaction tracking, and multi-agent AI capabilities.

  • Implements a full-stack web application with FastAPI backend and HTML/JavaScript frontend
  • Includes user interaction tracking and feedback collection system
  • Adds PDF document analysis functionality
  • Provides integration with Databricks Genie spaces and serving endpoints

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
agent_genie/tracking.py User interaction tracking and feedback management system
agent_genie/templates/index.html Complete frontend UI with chat interface and analytics features
agent_genie/table_extraction.py Unity Catalog table and column metadata extraction utilities
agent_genie/helper.py Core helper functions for Databricks Genie API integration
agent_genie/requirements.txt Python dependencies for the application
agent_genie/manual_ai_content.py Manual content storage for AI function documentation
agent_genie/databricks.yml Databricks bundle configuration for deployment
agent_genie/app.yaml Application configuration with environment variables
agent_genie/app.py Flask application with chat endpoint and model integration
Various manifest and config files Bundle metadata and development configuration
Comments suppressed due to low confidence (3)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexott
Copy link
Contributor

alexott commented Sep 20, 2025

first commit is still unsigned so we can't merge it

@alexott alexott requested a review from Copilot September 20, 2025 08:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

agent_genie/app.yaml:1

  • API keys should not be hardcoded in configuration files. Use secure secret management or environment variables that reference secrets.
command: [

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nitinaggarwal-databricks nitinaggarwal-databricks force-pushed the agent-genie++ branch 6 times, most recently from 39cd25a to d6626ce Compare October 27, 2025 03:42
Copy link
Author

@nitinaggarwal-databricks nitinaggarwal-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alexott alexott requested a review from Copilot October 31, 2025 12:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

agent_genie/helper.py:1

  • The dotenv loading appears outside the if name guard in a helper module that may be imported. Consider moving this to the main application entry point (app.py) or wrapping it in a function to provide explicit control over when environment variables are loaded.
from __future__ import annotations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"content": user_query

},
{"role":"user", "content":str(response) + " # Important: Returnt above user's content as response only without modification"},
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'Returnt' to 'Return'

Suggested change
{"role":"user", "content":str(response) + " # Important: Returnt above user's content as response only without modification"},
{"role":"user", "content":str(response) + " # Important: Return above user's content as response only without modification"},

Copilot uses AI. Check for mistakes.
logger.info("Using global SCHEMA_INFO as fallback")
schema_info = f"Available Columns: {SCHEMA_INFO}"
else:
#pass
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented-out 'pass' statement should be removed. The comment on line 189 is sufficient without the empty pass statement.

Suggested change
#pass

Copilot uses AI. Check for mistakes.
"- Output ONLY the SQL function query—no explanation, no markdown.\n"

)
#"- If two or more functions are referenced, try to apply them all if relevant.\n"
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This commented-out instruction appears to be important guidance for multi-function queries. Either uncomment and include it in the prompt, or remove it entirely if it's no longer relevant.

Suggested change
#"- If two or more functions are referenced, try to apply them all if relevant.\n"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants