Fix issue #300: Need File.from_uri() method#1647
Closed
icysun wants to merge 2 commits intodatachain-ai:mainfrom
Closed
Fix issue #300: Need File.from_uri() method#1647icysun wants to merge 2 commits intodatachain-ai:mainfrom
icysun wants to merge 2 commits intodatachain-ai:mainfrom
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I've been looking at issue #300 and thought I could help out.
What I did
I added some improvements to address the issue:
I also added some tests to make sure everything works as expected.
Testing
I've tested this locally and it works fine:
Why this helps
These changes should fix the issue while making the code more robust. I tried to keep it simple and followed the existing code style.
Let me know if you have any questions or if there's anything else I can help with!
Thanks for the great project! 🙏