-
Notifications
You must be signed in to change notification settings - Fork 2
Install slither #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install slither #11
Conversation
…allation instructions
…ll and update Slither workflow
… check for PR comments
Slither reportSummary
uninitialized-localImpact: Medium
|
…tAcknowledgementCall function
| @@ -0,0 +1,32 @@ | |||
| module.exports = async ({ github, context, header, body }) => { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied from https://github.com/datachainlab/mutb-sc-poc
| @@ -1,16 +0,0 @@ | |||
| // SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted as it is for truffle use only
mattsu6666
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a comment. There are almost no issues.
.github/workflows/slither.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not using git submodules, so this line seems unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix: 75becac
mattsu6666
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ref: https://github.com/datachainlab/mutb-sc-poc