Skip to content

Conversation

@YukiTsuchida
Copy link
Contributor

@YukiTsuchida YukiTsuchida commented Oct 24, 2025

  • Introduced the static analysis tool Slither into CI
  • Fixed the codes

Ref: https://github.com/datachainlab/mutb-sc-poc

@datachainlab datachainlab deleted a comment from github-actions bot Oct 24, 2025
@datachainlab datachainlab deleted a comment from github-actions bot Oct 24, 2025
@github-actions
Copy link

Slither report

Summary

uninitialized-local

Impact: Medium
Confidence: Medium

PacketAcknowledgementCall.Data memory ack;

@@ -0,0 +1,32 @@
module.exports = async ({ github, context, header, body }) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YukiTsuchida YukiTsuchida changed the base branch from main to install-unit-test October 24, 2025 03:21
@@ -1,16 +0,0 @@
// SPDX-License-Identifier: MIT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted as it is for truffle use only

@YukiTsuchida YukiTsuchida changed the base branch from install-unit-test to main October 24, 2025 06:22
@YukiTsuchida YukiTsuchida self-assigned this Oct 26, 2025
Copy link
Member

@mattsu6666 mattsu6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment. There are almost no issues.

steps:
- uses: actions/checkout@v4
with:
submodules: recursive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not using git submodules, so this line seems unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: 75becac

Copy link
Member

@mattsu6666 mattsu6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YukiTsuchida YukiTsuchida merged commit c33e5b7 into main Oct 27, 2025
3 checks passed
@YukiTsuchida YukiTsuchida deleted the install-slither branch January 16, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants