feat: IInitiator #17
Merged
feat: IInitiator #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
YukiTsuchida
commented
Nov 5, 2025
| npm run fmt:sol | ||
|
|
||
| git add -A | ||
| npx lint-staged |
Contributor
Author
There was a problem hiding this comment.
There was a bug where files without stage were committed, so fixed it by using lint-staged.
YukiTsuchida
commented
Nov 5, 2025
| @@ -0,0 +1,77 @@ | |||
| syntax = "proto3"; | |||
Contributor
Author
There was a problem hiding this comment.
Built with reference to the proto of the cross repository
YukiTsuchida
commented
Nov 5, 2025
| @@ -0,0 +1,58 @@ | |||
| syntax = "proto3"; | |||
Contributor
Author
There was a problem hiding this comment.
Built with reference to the proto of the cross repository
YukiTsuchida
commented
Nov 6, 2025
| "clean": "rm -rf build", | ||
| "test": "forge test -vvv", | ||
| "lint:sol": "solhint -f table 'src/**/*.sol' 'test/**/*.sol' 'script/**/*.sol'", | ||
| "lint:sol": "solhint -f table --max-warnings 0 'src/**/*.sol' 'test/**/*.sol' 'script/**/*.sol'", |
Contributor
Author
There was a problem hiding this comment.
Treat solhint warnings as errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.