Skip to content

feat: implement selfXCC function #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
YukiTsuchida wants to merge 2 commits into from
Closed

feat: implement selfXCC function #23

YukiTsuchida wants to merge 2 commits into from

Conversation

@YukiTsuchida
Copy link
Contributor

@YukiTsuchida YukiTsuchida commented Nov 12, 2025 •
edited
Loading

  • Implemented selfXCC() in Initiator.
  • Added unit tests for selfXCC().

@YukiTsuchida YukiTsuchida marked this pull request as ready for review November 12, 2025 04:12
@YukiTsuchida YukiTsuchida self-assigned this Nov 12, 2025
@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

LCOV of commit 0cc114f during Coverage Report #85

Summary coverage rate:
  lines......: 98.1% (206 of 210 lines)
  functions..: 100.0% (43 of 43 functions)
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  src/core/Initiator.sol             |10.3%     39| 0.0%     4|    -      0

Full coverage report

@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited by YukiTsuchida
Loading

Slither report

Summary

shadowing-local

Impact: Low
Confidence: High

cross-solidity/src/core/Initiator.sol

Line 68 in 9917134

ChannelInfo.Data memory selfXCC = ChannelInfo.Data({port: "", channel: ""});

YukiTsuchida
YukiTsuchida commented Nov 12, 2025
View reviewed changes
src/core/Initiator.sol
});
}

function selfXCC() external view virtual override returns (QuerySelfXCCResponse.Data memory) {
Copy link
Contributor Author

@YukiTsuchida YukiTsuchida Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: https://github.com/datachainlab/cross/blob/master/x/core/initiator/keeper/grpc_query.go

@YukiTsuchida YukiTsuchida marked this pull request as draft November 13, 2025 07:40
@YukiTsuchida YukiTsuchida deleted the impl-initiator-self-xcc branch January 16, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsu6666 mattsu6666 Awaiting requested review from mattsu6666

Assignees

@YukiTsuchida YukiTsuchida

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@YukiTsuchida