Skip to content

fix: Initializable ERC20TransferModule #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
YukiTsuchida merged 5 commits into from
Dec 10, 2025
Merged

fix: Initializable ERC20TransferModule #44

YukiTsuchida merged 5 commits into from
Dec 10, 2025

Conversation

@YukiTsuchida
Copy link
Contributor

@YukiTsuchida YukiTsuchida commented Dec 4, 2025

Because in the original design the constructor for CrossModule required an IContractModule, and ERC20TransferModule required CrossModule, creating a circular dependency that prevented deployment, I made ERC20TransferModule initializable instead.

@YukiTsuchida YukiTsuchida self-assigned this Dec 4, 2025
@YukiTsuchida YukiTsuchida changed the title fix: Initializable erc20transfermodule fix: Initializable ERC20TransferModule Dec 4, 2025
@YukiTsuchida YukiTsuchida marked this pull request as ready for review December 4, 2025 05:45
@github-actions
Copy link

github-actions bot commented Dec 4, 2025 •
edited
Loading

LCOV of commit 6d9a51e during Coverage Report #227

Summary coverage rate:
  lines......: 97.5% (583 of 598 lines)
  functions..: 95.3% (101 of 106 functions)
  branches...: no data found

Files changed coverage rate:
                                         |Lines       |Functions  |Branches    
  Filename                               |Rate     Num|Rate    Num|Rate     Num
  =============================================================================
  src/example/ERC20TransferModule.sol    |21.2%     33| 0.0%     7|    -      0

Full coverage report

@datachainlab datachainlab deleted a comment from github-actions bot Dec 4, 2025
mattsu6666
mattsu6666 reviewed Dec 5, 2025
View reviewed changes
src/example/ERC20TransferModule.sol Outdated
constructor(address _crossModule, address _token) {
CROSS_MODULE = _crossModule;
TOKEN = IERC20(_token);
function initialize(address _crossModule, address _token) external initializer {
Copy link
Member

@mattsu6666 mattsu6666 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialize can be called by anyone. Isn’t there a risk that it could be initialized maliciously? It might be better to restrict it using Ownable or AccessControl.

Copy link
Contributor Author

@YukiTsuchida YukiTsuchida Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: cd171a6

@datachainlab datachainlab deleted a comment from github-actions bot Dec 10, 2025
mattsu6666
mattsu6666 approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@mattsu6666 mattsu6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM☀️

@YukiTsuchida YukiTsuchida merged commit 8f9934f into feature/coordinator Dec 10, 2025
5 checks passed
@YukiTsuchida YukiTsuchida mentioned this pull request Dec 12, 2025
Merged
@YukiTsuchida YukiTsuchida deleted the initializable-erc20transfermodule branch January 16, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsu6666 mattsu6666 mattsu6666 approved these changes

Assignees

@YukiTsuchida YukiTsuchida

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YukiTsuchida @mattsu6666