Skip to content

Conversation

@YukiTsuchida
Copy link
Contributor

@YukiTsuchida YukiTsuchida commented Dec 9, 2025

  • Issue: _sign() fails during extSignTx.
  • Cause: A bug caused distinct hash values to be generated for two Account.Data instances that should be treated as identical. This has been fixed.
{
  "Id": "AHMVQM1gYJkda5xXzilZmNm8L6s=",
  "AuthType": {
    "Mode": 3,
    "Option": {
      "TypeUrl": "/verifier.sample.extension",
      "Value": ""
    }
  }
}
{
  "Id": "AHMVQM1gYJkda5xXzilZmNm8L6s=",
  "AuthType": {
    "Mode": 3,
    "Option": {
      "TypeUrl": "/verifier.sample.extension",
      "Value": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEDCUmZoBBegKy+RoE0WqlxsOxiRVr+pMkiz8ZhTeZjdUQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABBMKEs65z9pO27V0xKSJtC7fZApRXsLaWjZCJcoLBvf3JidQvNxtifN7FKFFeiocKtOsTXVvgm1qwRLUst0CGrlhwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
    }
  }
}

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

LCOV of commit 987bd8f during Coverage Report #229

Summary coverage rate:
  lines......: 97.5% (585 of 600 lines)
  functions..: 95.3% (101 of 106 functions)
  branches...: no data found

Files changed coverage rate:
                                         |Lines       |Functions  |Branches    
  Filename                               |Rate     Num|Rate    Num|Rate     Num
  =============================================================================
  src/core/TxAuthManager.sol             |17.1%     82| 0.0%    14|    -      0

Full coverage report

@YukiTsuchida YukiTsuchida marked this pull request as ready for review December 10, 2025 01:28
@mattsu6666 mattsu6666 self-requested a review December 10, 2025 05:00
Copy link
Member

@mattsu6666 mattsu6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@YukiTsuchida YukiTsuchida changed the base branch from initializable-erc20transfermodule to feature/coordinator December 10, 2025 06:42
@YukiTsuchida YukiTsuchida merged commit 7218492 into feature/coordinator Dec 10, 2025
5 checks passed
@YukiTsuchida YukiTsuchida mentioned this pull request Dec 12, 2025
@YukiTsuchida YukiTsuchida deleted the enhance-accountKey branch January 16, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants