Skip to content

fix: use relative imports in CrossStore.sol and ICoordinator.sol #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
YukiTsuchida merged 1 commit into from
Dec 12, 2025
Merged

fix: use relative imports in CrossStore.sol and ICoordinator.sol #46

YukiTsuchida merged 1 commit into from
Dec 12, 2025

Conversation

@YukiTsuchida
Copy link
Contributor

@YukiTsuchida YukiTsuchida commented Dec 12, 2025 •
edited
Loading

Description

Replaced absolute imports (src/proto/...) with relative paths in CrossStore.sol and ICoordinator.sol.

Motivation

Using absolute paths causes build errors when this repository is installed as a dependency, as the compiler attempts to resolve src from the consumer's project root. This fix eliminates the need for users to configure manual remappings.

@YukiTsuchida YukiTsuchida changed the title Fix import fix: replace absolute imports with relative paths in CrossStore.sol and ICoordinator.sol Dec 12, 2025
@YukiTsuchida YukiTsuchida changed the title fix: replace absolute imports with relative paths in CrossStore.sol and ICoordinator.sol fix: use relative imports in CrossStore.sol and ICoordinator.sol Dec 12, 2025
@github-actions
Copy link

github-actions bot commented Dec 12, 2025

LCOV of commit a7f3a4a during Coverage Report #232

Summary coverage rate:
  lines......: 97.5% (585 of 600 lines)
  functions..: 95.3% (101 of 106 functions)
  branches...: no data found

Files changed coverage rate:
                                         |Lines       |Functions  |Branches    
  Filename                               |Rate     Num|Rate    Num|Rate     Num
  =============================================================================
  src/core/CrossStore.sol                | 100%      3| 0.0%     3|    -      0

Full coverage report

@YukiTsuchida YukiTsuchida marked this pull request as ready for review December 12, 2025 01:59
@YukiTsuchida YukiTsuchida self-assigned this Dec 12, 2025
@YukiTsuchida YukiTsuchida mentioned this pull request Dec 12, 2025
Merged
mattsu6666
mattsu6666 approved these changes Dec 12, 2025
View reviewed changes
Copy link
Member

@mattsu6666 mattsu6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👏

@YukiTsuchida YukiTsuchida merged commit e67f3db into feature/coordinator Dec 12, 2025
5 checks passed
@YukiTsuchida YukiTsuchida mentioned this pull request Dec 12, 2025
Merged
@YukiTsuchida YukiTsuchida deleted the fix-import-proto branch January 16, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsu6666 mattsu6666 mattsu6666 approved these changes

Assignees

@YukiTsuchida YukiTsuchida

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YukiTsuchida @mattsu6666