debug build not to call txpool_contentFrom api #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
dai1975
force-pushed
the
buildtag-debug_txpool
branch
2 times, most recently
from
8ea9a7f to
95bade2
Compare
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
dai1975
force-pushed
the
buildtag-debug_txpool
branch
from
95bade2 to
f25bc08
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a debug build for the txpool_contentFrom API call, which on non-debug builds makes the RPC call as usual but returns an empty result in debug builds when the RELAYER_SKIP_TXPOOL_CONTENT_FROM environment variable is set.
- Introduces a dedicated debug file to handle the debug-specific behavior.
- Removes the redundant ContentFrom implementation from pkg/client/txpool/txpool.go, routing calls to the new implementations as appropriate.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/client/txpool/txpool_content_from.go | Implements the normal behavior for the RPC call |
| pkg/client/txpool/txpool_content_from.debug.go | Implements the debug behavior to skip the RPC call if env is set |
| pkg/client/txpool/txpool.go | Removes previous duplicate implementation of ContentFrom |
Comments suppressed due to low confidence (1)
pkg/client/txpool/txpool_content_from.debug.go:17
- Consider adding an inline comment inside this conditional block to clarify that setting RELAYER_SKIP_TXPOOL_CONTENT_FROM to '1' purposefully skips the txpool_contentFrom RPC call in debug builds.
if ok && val == "1" {
added 2 commits
June 24, 2025 07:28
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Contributor
|
@dai1975 Please rename txpool_content_from*.go into content_from*.go since they are in txpool package and the prefix in the file names are redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lcpbridge.atlassian.net/browse/LO-7246
Anvil blockchain node is useful for local test, but it does not support txpool_contentFrom api.
In some usecase, txpool_contentFrom call is not required so we prepare debug build not to call the api and use empty data as its response.