Skip to content

force assign geth's S256() as Curve value #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dai1975 merged 2 commits into from
Jun 13, 2025
Merged

force assign geth's S256() as Curve value #4

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce80e1f
force assign geth's S256() as Curve value
Jun 12, 2025
96eb422
Update pkg/wallet/wallet.go
dai1975 Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pkg/wallet/wallet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"strings"

"github.com/btcsuite/btcd/btcutil/hdkeychain"
gethcrypto "github.com/ethereum/go-ethereum/crypto"
"github.com/btcsuite/btcd/chaincfg"
bip39 "github.com/tyler-smith/go-bip39"
)
Expand Down Expand Up @@ -124,7 +125,17 @@ func GetPrvKeyFromHDWallet(seed []byte, hp *HDPathLevel) (*ecdsa.PrivateKey, err
if err != nil {
return nil, err
}
return btcecPrivKey.ToECDSA(), nil

ecdsaPrivKey := btcecPrivKey.ToECDSA()

// In !cgo environments, curve data type of go-ethereum's S256() is differ from btcsuite's one.
// So compareing curve object in go-ethereum/crypto/signature_nocgo.go fails.
// To ensure consistency, we replace the Curve with gethcrypto.S256().
if ecdsaPrivKey.Curve.Params().Name == "secp256k1" && ecdsaPrivKey.Curve != gethcrypto.S256() {
ecdsaPrivKey.Curve = gethcrypto.S256()
}

return ecdsaPrivKey, nil
}

func GetPrvKeyFromMnemonicAndHDWPath(mnemonic, path string) (*ecdsa.PrivateKey, error) {
Expand Down