Add ForkSpec into ClientState #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 3, 2025 19:22
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
added 21 commits
March 17, 2025 15:16
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
added 17 commits
March 23, 2025 11:31
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
There was a problem hiding this comment.
Pull Request Overview
This PR adds fork specification support to ClientState by introducing a new ForkSpec message and integrating a network-based fork rule system for localnet, testnet, and mainnet, intended for use after the Pascal HF.
- Introduces a ForkSpec protobuf message and integrates it into ClientState.
- Adds a Network field in configuration (including generated proto code) and updates validation accordingly.
- Adjusts test data and configuration to use the new fork specification logic.
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tool/testdata/internal/histroy.go | Moves import statements; consider renaming the file for clarity. |
| tool/testdata/internal/common.go | Adds a default network setting to ProverConfig. |
| tool/testdata/README.md | Updates documentation hints for localnet fixture usage. |
| proto/relayer/provers/parlia/config/config.proto | Adds the Network field to ProverConfig. |
| proto/ibc/lightclients/parlia/v1/parlia.proto | Introduces the ForkSpec message and adds fork_specs to ClientState. |
| module/prover_test.go | Updates Prover testing with a network setting for fork parameters. |
| module/prover.go | Integrates fork spec retrieval into initial state construction. |
| module/fork_spec.go | Adds fork parameter definitions for each network type. |
| module/config.pb.go | Reflects the configuration changes for the new Network field. |
| module/config.go | Validates the Network field against known networks. |
Files not reviewed (2)
- e2e/config/demo/ibc-0.json: Language not supported
- e2e/config/demo/ibc-1.json: Language not supported
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
3100
approved these changes
Apr 7, 2025
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
NonStop from Pascal to Lorentz HF
Support msec timestamp and 500 epoch length in BEP520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define fork rule per network (localnet, testnet, mainne).
Support only after Pascal HF.