Use context appropriately #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abicky
force-pushed
the
use-context-appropriately
branch
from
9903699 to
5a0c785
Compare
Signed-off-by: abicky <takeshi.arabiki@datachain.jp>
abicky
force-pushed
the
use-context-appropriately
branch
from
5a0c785 to
372d6ac
Compare
abicky
force-pushed
the
use-context-appropriately
branch
from
372d6ac to
5ac6c73
Compare
Signed-off-by: Takeshi Arabiki <takeshi.arabiki@datachain.jp>
Signed-off-by: Takeshi Arabiki <takeshi.arabiki@datachain.jp>
Signed-off-by: Takeshi Arabiki <takeshi.arabiki@datachain.jp>
Signed-off-by: Takeshi Arabiki <takeshi.arabiki@datachain.jp>
Signed-off-by: Takeshi Arabiki <takeshi.arabiki@datachain.jp>
abicky
force-pushed
the
use-context-appropriately
branch
from
5ac6c73 to
1589dbe
Compare
abicky
commented
Mar 16, 2025
| func (c *ethChain) GetProof(address common.Address, storageKeys [][]byte, blockNumber *big.Int) (*client.StateProof, error) { | ||
| return c.Client().GetProof(address, storageKeys, blockNumber) | ||
| func (c *ethChain) GetProof(ctx context.Context, address common.Address, storageKeys [][]byte, blockNumber *big.Int) (*client.StateProof, error) { | ||
| return c.Client().GetProof(ctx, address, storageKeys, blockNumber) |
Contributor
Author
There was a problem hiding this comment.
The signature has changed in the PR datachainlab/ethereum-ibc-relay-chain#64 (comment).
Signed-off-by: Takeshi Arabiki <takeshi.arabiki@datachain.jp>
abicky
force-pushed
the
use-context-appropriately
branch
from
1589dbe to
1b58af6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the subsequent PR of #51 and replaces
context.TODO()with an appropriate context.