-
Notifications
You must be signed in to change notification settings - Fork 1
Support tracing feature #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abicky
commented
May 14, 2025
abicky
commented
May 14, 2025
| ) | ||
|
|
||
| // See https://github.com/prysmaticlabs/grpc-gateway/issues/2 | ||
| replace github.com/grpc-ecosystem/grpc-gateway/v2 => github.com/prysmaticlabs/grpc-gateway/v2 v2.3.1-0.20230315201114-09284ba20446 |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed this replace directive for the same reason as datachainlab/ethereum-ibc-relay-prover#38 (comment)
b4cb86a to
762522d
Compare
Signed-off-by: Takeshi Arabiki <takeshi.arabiki@datachain.jp>
Signed-off-by: Takeshi Arabiki <takeshi.arabiki@datachain.jp>
siburu
approved these changes
Jun 2, 2025
Contributor
siburu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for tracing features using tracing bridges, one of which was introduced in hyperledger-labs/yui-relayer#162.
To allow us to try the feature with minimal effort, this PR only focuses on using tracing bridges and logger methods with the
Contextsuffix.Since the tracing bridge affects code that uses type assertions and type information (
%T), so I have verified that there is no remaining code to be updated as follows:This PR modifies the type of the embedded struct within
ProvableChain, so modules that depends on type assertions need to usecoreutil.UnwrapProverinstead.For example, the following code:
must be updated to: