Fix Maxwell Height #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2025 08:25
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
abicky
approved these changes
May 26, 2025
| hardForks[indexLorentzHF].HeightOrTimestamp = &ForkSpec_Height{Height: 49791365} | ||
| // https://github.com/bnb-chain/bsc/blob/256d8811f441c29cb0812943dc660ac13192829c/params/config.go#L239 | ||
| hardForks[indexMaxwellHF].HeightOrTimestamp = &ForkSpec_Timestamp{Timestamp: 1748243100 * 1000} | ||
| hardForks[indexMaxwellHF].HeightOrTimestamp = &ForkSpec_Height{Height: 52552978} |
Contributor
There was a problem hiding this comment.
📝 I have also confirmed that GetBoundaryHeight returns the same height:
{
"time": "2025-05-26T08:30:13.58205096Z",
"level": "DEBUG",
"source": {
"function": "github.com/datachainlab/ibc-parlia-relay/module.GetBoundaryHeight",
"file": "/go/pkg/mod/github.com/datachainlab/ibc-parlia-relay@v0.3.16-ts/module/fork_spec.go",
"line": 249
},
"msg": "seek fork height found",
"currentHeight": 52559390,
"ts": 1748243100000,
"boundaryHeight": 52552978
}
yoshidan
added a commit
that referenced
this pull request
May 29, 2025
* fix audit Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp> * add elc version Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp> * Maxwell HF (#66) * Fix Maxwell Height (#67) --------- Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp> Co-authored-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix after
2025-05-26 07:05:00 AM UTChttps://testnet.bscscan.com/block/52552977 is
May-26-2025 07:04:59 AM +UTChttps://testnet.bscscan.com/block/52552978 is
May-26-2025 07:05:01 AM +UTC. <- first block after Maxwell Timestamphttps://testnet.bscscan.com/block/52552979 is
May-26-2025 07:05:01 AM +UTC