Support the new interface of SetupHeadersForUpdate, which returns chan
#68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siburu
force-pushed
the
feature/relayer-v0.5.13-op
branch
from
ea2576d to
5ff405f
Compare
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
siburu
force-pushed
the
feature/relayer-v0.5.13-op
branch
from
e06d27b to
cf482af
Compare
siburu
changed the title
SetupHeadersForUpdate, which returns chanSetupHeadersForUpdate, which returns chan
yoshidan
reviewed
Jun 23, 2025
module/prover.go
Outdated
| return pr.SetupHeadersForUpdateByLatestHeight(ctx, cs.GetLatestHeight(), header) | ||
| if headers, err := pr.SetupHeadersForUpdateByLatestHeight(ctx, cs.GetLatestHeight(), header); err != nil { | ||
| return nil, err | ||
| } else if headers == nil { |
Contributor
There was a problem hiding this comment.
Even if headers is nil, headers... does not cause panic.
This can reduce the number of branches.
if headers, err := pr.SetupHeadersForUpdateByLatestHeight(ctx, cs.GetLatestHeight(), header); err != nil {
return nil, err
} else {
return core.MakeHeaderStream(headers...), nil
}
Contributor
Author
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
yoshidan
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.