Skip to content

Improve validation of risc0 verifier info length #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluele merged 1 commit into from
Mar 12, 2025
Merged

Improve validation of risc0 verifier info length #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contracts/LCPClientZKDCAPBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,8 @@ abstract contract LCPClientZKDCAPBase is LCPClientBase {
if (uint8(verifierInfo[0]) != ZKVM_TYPE_RISC_ZERO) {
revert LCPClientZKDCAPInvalidVerifierInfoZKVMType();
}
if (vlen < 64) {
// risc0 verifier info should be 64 bytes
if (vlen != 64) {
revert LCPClientZKDCAPInvalidVerifierInfoLength();
}
// 32..64 bytes: image ID
Expand Down
7 changes: 7 additions & 0 deletions test/LCPClientZKDCAPTest.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,7 @@ contract LCPClientZKDCAPTest is BasicTest {
vm.warp(ZKDCAPTestHelper.TEST_TIMESTAMP);
bytes memory consensusStateBytes = LCPProtoMarshaler.marshal(defaultConsensusState());
IbcLightclientsLcpV1ClientState.Data memory clientState = defaultClientState();
bytes memory valid_zkdcap_verifier_info = clientState.zkdcap_verifier_infos[0];
clientState.zkdcap_verifier_infos[0] = new bytes(0);
bytes memory clientStateBytes = LCPProtoMarshaler.marshal(clientState);
vm.expectRevert();
Expand All @@ -689,6 +690,12 @@ contract LCPClientZKDCAPTest is BasicTest {
clientStateBytes = LCPProtoMarshaler.marshal(clientState);
vm.expectRevert();
lc.initializeClient(clientId, clientStateBytes, consensusStateBytes);

clientState.zkdcap_verifier_infos = new bytes[](1);
clientState.zkdcap_verifier_infos[0] = abi.encodePacked(valid_zkdcap_verifier_info, bytes1(0x0));
clientStateBytes = LCPProtoMarshaler.marshal(clientState);
vm.expectRevert();
lc.initializeClient(clientId, clientStateBytes, consensusStateBytes);
}

function testInitializeClientInvalidValues() public {
Expand Down
Loading