Add tcb_evaulation_data_number option to zkdcap command
#133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Kimura <jun.kimura@datachain.jp>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the zkdcap command to add a new option for specifying the TCB Evaluation Data Number, replacing the previous boolean-based update policy. It also updates dependency revisions across multiple Cargo.toml files to reference the new commit version.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/src/lib.rs | Changed PCSClient creation to use an Option instead of a boolean value |
| tests/integration/Cargo.toml | Updated zkdcap dependency revision |
| modules/remote-attestation/src/dcap.rs | Changed PCSClient creation to use an Option |
| modules/remote-attestation/Cargo.toml | Updated multiple dcap dependencies revisions |
| modules/lcp-client/Cargo.toml | Updated zkdcap dependency revision |
| modules/attestation-report/Cargo.toml | Updated zkdcap dependency revision |
| app/src/commands/attestation.rs | Replaced the update_policy option and accompanying enum with tcb_evaluation_data_number option |
| app/Cargo.toml | Updated zkdcap dependency revision |
| long = "update_policy", | ||
| default_value = "early", | ||
| help = "Update policy (early(default) or standard)" | ||
| long = "tcb_evaluation_data_number", |
There was a problem hiding this comment.
[nitpick] Consider specifying a default_value for tcb_evaluation_data_number if a default behavior is expected, or update the help message to clarify that the absence of a value implies the latest available TCB Evaluation Data Number.
Signed-off-by: Jun Kimura <jun.kimura@datachain.jp>
bluele
force-pushed
the
tcb-evaluation-policy
branch
from
4cd846c to
506564f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.