Skip to content

Conversation

@siburu
Copy link
Collaborator

@siburu siburu commented Jul 8, 2025

No description provided.

@siburu siburu requested a review from Copilot July 8, 2025 06:40

This comment was marked as outdated.

@siburu siburu requested a review from Copilot July 8, 2025 11:27

This comment was marked as outdated.

Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu siburu requested a review from Copilot July 8, 2025 11:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive design specification for the Optimism Enclave Light Client (ELC), detailing its architecture, data structures, key operations, security assumptions, and misbehaviour detection procedures.

  • Introduces DESIGN.md capturing protocol overview, architecture, and verification workflows
  • Defines core data structures (ClientState, ConsensusState, Header) and key functions
  • Outlines security assumptions and provides Rust pseudocode for misbehaviour detection
Comments suppressed due to low confidence (3)

DESIGN.md:13

  • Section 2 states there are only two verification operations (update_client and verify_membership), but later the spec includes verify_non_membership. Please update the overview to list all supported operations for consistency.
Functionally, OP ELC provides two types of verification operations, which together fulfill the stated objective:

DESIGN.md:58

  • [nitpick] The sub-bullets under Preimage Oracle are not indented, which can reduce readability in rendered Markdown. Consider indenting the descriptions by two spaces under each main bullet.
- Online Preimage Oracle

DESIGN.md:144

  • [nitpick] The Unicode approximate symbol (≒) may not render uniformly across all platforms. Consider replacing it with a plain-text alternative, e.g., "approximately equals", for clarity.
                - logic: `optimism_derivation::run` (≒ `kona_client::single::run`)

@yoshidan yoshidan merged commit a8a2ef2 into main Jul 8, 2025
1 check passed
@yoshidan yoshidan deleted the feature/doc branch September 4, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants