Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
NOTE: This project is currently under heavy development. Features may change or break.

## Supported Versions
- [lcp v0.2.14](https://github.com/datachainlab/lcp/releases/tag/v0.2.14)
- [optimism v1.13.1](https://github.com/ethereum-optimism/optimism/tree/v1.13.1)
- [lcp v0.2.17](https://github.com/datachainlab/lcp/releases/tag/v0.2.17)
- [optimism v1.14.1](https://github.com/ethereum-optimism/optimism/tree/v1.14.1)

## Related project

Expand Down
95 changes: 24 additions & 71 deletions derivation/src/derivation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::errors::Error;
use crate::oracle::{MemoryOracleClient, NopeHintWriter};
use alloc::sync::Arc;
use alloy_consensus::Header;
use alloy_primitives::{keccak256, Sealed, B256};
use alloy_primitives::{Sealed, B256};
use core::clone::Clone;
use core::fmt::Debug;
use kona_client::fpvm_evm::FpvmOpEvmFactory;
Expand All @@ -21,7 +21,7 @@ use kona_proof::{
l2::OracleL2ChainProvider,
BootInfo,
};
use kona_registry::L1_CONFIGS;
use kona_registry::{L1_CONFIGS, ROLLUP_CONFIGS};
use serde::{Deserialize, Serialize};

#[derive(Clone, Debug, Deserialize, Serialize)]
Expand Down Expand Up @@ -50,22 +50,16 @@ impl Derivation {
pub fn verify(
&self,
chain_id: u64,
rollup_config: &RollupConfig,
oracle: MemoryOracleClient,
) -> Result<(Header, u64), Error> {
kona_proof::block_on(self.run(chain_id, rollup_config, oracle))
kona_proof::block_on(self.run(chain_id, oracle))
}

/// Run the derivation pipeline to verify the claimed L2 output root.
/// This is almost the same as kona-client.
async fn run(
&self,
chain_id: u64,
rollup_config: &RollupConfig,
oracle: MemoryOracleClient,
) -> Result<(Header, u64), Error> {
verify_config(rollup_config, &oracle).await?;
let l1_config = load_l1_config(rollup_config, &oracle).await?;
async fn run(&self, chain_id: u64, oracle: MemoryOracleClient) -> Result<(Header, u64), Error> {
let rollup_config = load_rollup_config(chain_id, &oracle).await?;
let l1_config = load_l1_config(&rollup_config, &oracle).await?;
let boot = &BootInfo {
l1_head: self.l1_head_hash,
agreed_l2_output_root: self.agreed_l2_output_root,
Expand Down Expand Up @@ -144,23 +138,25 @@ impl Derivation {
}
}

async fn verify_config(
rollup_config: &RollupConfig,
async fn load_rollup_config(
chain_id: u64,
oracle: &MemoryOracleClient,
) -> Result<(), Error> {
let config_key = PreimageKey::new_local(L2_ROLLUP_CONFIG_KEY.to());
let in_preimage = oracle
.get(config_key)
.await
.map_err(|e| Error::UnexpectedPreimageKey {
source: e,
key: config_key.key_value().to_be_bytes(),
})?;
let in_state = serde_json::to_vec(rollup_config)?;
if keccak256(&in_state) != keccak256(&in_preimage) {
return Err(Error::InvalidRollupConfig(in_preimage, in_state));
}
Ok(())
) -> Result<RollupConfig, Error> {
let rollup_config = if let Some(config) = ROLLUP_CONFIGS.get(&chain_id) {
config.clone()
} else {
// for devnet only
let config_key = PreimageKey::new_local(L2_ROLLUP_CONFIG_KEY.to());
let ser_cfg = oracle
.get(config_key)
.await
.map_err(|e| Error::UnexpectedPreimageKey {
source: e,
key: config_key.key_value().to_be_bytes(),
})?;
serde_json::from_slice(&ser_cfg).map_err(Error::SerdeError)?
};
Ok(rollup_config)
}

async fn load_l1_config(
Expand All @@ -183,46 +179,3 @@ async fn load_l1_config(
};
Ok(l1_config)
}

#[cfg(test)]
mod test {
use crate::derivation::verify_config;
use crate::errors::Error;
use crate::oracle::MemoryOracleClient;
use crate::types::Preimage;
use alloc::vec;
use kona_genesis::RollupConfig;
use kona_preimage::PreimageKey;
use kona_proof::boot::L2_ROLLUP_CONFIG_KEY;

#[test]
fn test_verify_config_not_found_error() {
let rollup_config = RollupConfig::default();
let oracle = MemoryOracleClient::default();
let err = kona_proof::block_on(verify_config(&rollup_config, &oracle)).unwrap_err();
match err {
Error::UnexpectedPreimageKey { .. } => {}
_ => panic!("Unexpected error, got {:?}", err),
}
}

#[test]
fn test_verify_config_invalid_error() {
let rollup_config = RollupConfig::default();
let rollup_config2 = RollupConfig {
l2_chain_id: (rollup_config.l2_chain_id.id() + 1).into(),
..rollup_config.clone()
};

let preimage = vec![Preimage::new(
PreimageKey::new_local(L2_ROLLUP_CONFIG_KEY.to()),
serde_json::to_vec(&rollup_config2).unwrap(),
)];
let oracle = MemoryOracleClient::try_from(preimage).unwrap();
let err = kona_proof::block_on(verify_config(&rollup_config, &oracle)).unwrap_err();
match err {
Error::InvalidRollupConfig { .. } => {}
_ => panic!("Unexpected error, got {:?}", err),
}
}
}
2 changes: 0 additions & 2 deletions derivation/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ use kona_preimage::PreimageKey;

#[derive(thiserror::Error, Debug)]
pub enum Error {
#[error("InvalidRollupConfig: in_preimage={0:?}, in_state={1:?}")]
InvalidRollupConfig(Vec<u8>, Vec<u8>),
#[error("DuplicatePreimageKey: key={0:?}")]
UnexpectedDuplicatePreimageKey(PreimageKey),
#[error("InvalidClaim actual={0}, expected={1}")]
Expand Down
1 change: 0 additions & 1 deletion light-client/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ ethereum-consensus = { workspace = true }
ethereum-light-client-verifier = { workspace = true }

# Kona
kona-genesis = { workspace = true}
kona-protocol = { workspace = true}

# Alloy
Expand Down
Loading