Skip to content

DAT-8, S2: Add Misbehaviour implementation #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yoshidan merged 3 commits into from
Jul 2, 2025
Merged

DAT-8, S2: Add Misbehaviour implementation #8

yoshidan merged 3 commits into from
Jul 2, 2025

Conversation

@yoshidan
Copy link
Collaborator

@yoshidan yoshidan commented Jun 10, 2025 •
edited
Loading

  • L1 Misbehaviour
  • L2 Misbehaviour
  • unit test code
  • initial config(eg. storage slot) into ClientState

@yoshidan yoshidan marked this pull request as ready for review June 17, 2025 23:32
@yoshidan yoshidan requested review from siburu June 17, 2025 23:32
@yoshidan yoshidan force-pushed the feature/misbehavior branch from 7460b29 to 7f3f58c Compare June 21, 2025 05:54
@yoshidan yoshidan changed the title Add Misbehaviour implementation DAT-8: Add Misbehaviour implementation Jun 22, 2025
@yoshidan yoshidan changed the title DAT-8: Add Misbehaviour implementation DAT-8, S2: Add Misbehaviour implementation Jun 22, 2025
siburu
siburu reviewed Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshidan I have put some comments. The contents of the comments have been already discussed by us.

@yoshidan yoshidan force-pushed the feature/misbehavior branch 5 times, most recently from 9a434de to 4c2cbd3 Compare June 28, 2025 01:50
siburu
siburu reviewed Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshidan I have put some comments.

@yoshidan yoshidan force-pushed the feature/misbehavior branch from 4c2cbd3 to f74d130 Compare July 2, 2025 04:19
add misbehaviour / remove todo
64b1c06 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
@yoshidan yoshidan force-pushed the feature/misbehavior branch from f74d130 to 64b1c06 Compare July 2, 2025 04:24
@yoshidan yoshidan requested a review from siburu July 2, 2025 04:29
siburu
siburu approved these changes Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshidan LGTM, thank you!!

Naohiro Yoshida added 2 commits July 2, 2025 14:49
fix conflict
d5b8c59 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
fix test
5985acb 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
@yoshidan yoshidan merged commit 2155000 into main Jul 2, 2025
1 check passed
@yoshidan yoshidan deleted the feature/misbehavior branch September 4, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siburu siburu siburu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshidan @siburu