Use static RollupConfig #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
added 2 commits
October 25, 2025 10:07
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
siburu
reviewed
Oct 28, 2025
server/src/main.rs
Outdated
| chain_id | ||
| ); | ||
| let l2_config = l2_client.rollup_config().await?; | ||
| let l1_chain_config = config.l1_chain_config.as_ref().unwrap(); |
Collaborator
There was a problem hiding this comment.
Any reason why this part uses unwrap while other parts handle errors properly?
yoshidan
force-pushed
the
feature/use_static_rollup
branch
from
883984c to
29c54ae
Compare
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
yoshidan
force-pushed
the
feature/use_static_rollup
branch
from
29c54ae to
6d32380
Compare
siburu
reviewed
Oct 29, 2025
server/Cargo.toml
Outdated
|
|
||
| # optimism derivation | ||
| optimism-derivation = { git = "https://github.com/datachainlab/optimism-elc", rev = "v0.1.6", default-features = false } | ||
| optimism-derivation = { git = "https://github.com/datachainlab/optimism-elc", rev = "44d4019cd3fa354eb5a5915a4a2d094f9888404f", default-features = false } |
Collaborator
There was a problem hiding this comment.
This rev will be replaced with the tag that will be created after this PR is merged, right?
added 2 commits
October 29, 2025 11:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kona has RollupConfig for mainnet and sepolia.
We use RollupConfig from op-node for fallback.