Skip to content

Move resolve_account from update_client to verify_commitment #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yoshidan merged 8 commits into from
Mar 14, 2025
Merged

Move resolve_account from update_client to verify_commitment #84

yoshidan merged 8 commits into from
Mar 14, 2025

Conversation

@yoshidan
Copy link
Contributor

@yoshidan yoshidan commented Mar 7, 2025

No description provided.

Naohiro Yoshida added 3 commits March 7, 2025 17:55
move verify account from update_client to verify_membership
c604a50 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
fix test
c4df416 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
fix lint
7d683de 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
@yoshidan yoshidan changed the title Move resolve_account into verify_commitment Move resolve_account from update_client to verify_commitment Mar 7, 2025
@yoshidan yoshidan requested a review from 3100 March 8, 2025 04:32
3100
3100 reviewed Mar 10, 2025
View reviewed changes
@yoshidan yoshidan requested a review from bluele March 11, 2025 05:55
Naohiro Yoshida added 3 commits March 11, 2025 15:43
remove account proof
b3a09c9 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
fix testcode
6bd4956 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
fix test
c6d0e26 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
3100
3100 reviewed Mar 13, 2025
View reviewed changes
@yoshidan yoshidan force-pushed the feature/move_account_verify branch 2 times, most recently from 59e1365 to 4acb40a Compare March 13, 2025 03:25
fix github warning
bcabe47 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
@yoshidan yoshidan force-pushed the feature/move_account_verify branch from 4acb40a to bcabe47 Compare March 13, 2025 03:30
@bluele bluele requested a review from siburu March 14, 2025 02:58
siburu
siburu approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siburu siburu self-requested a review March 14, 2025 06:50
@bluele
Copy link
Member

bluele commented Mar 14, 2025

@yoshidan
[NITS] Should we remove the function eth_header_mut following the warning: https://github.com/datachainlab/parlia-elc/pull/84/files#diff-98593905abb552727b9a6265008748ad27c594ea86c62199ff93c4e6a9d95984R273 ?

siburu
siburu approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, again!

@siburu
Copy link
Contributor

siburu commented Mar 14, 2025

eth_header_mut is expected to be used only in a test code enabled by the feature flag dev, right?
If so, eth_header_mut itself should be under #[cfg(feature = "dev")].

avoid github warning
3f16df2 
Signed-off-by: Naohiro Yoshida <naohiro.yoshida@datachain.jp>
@yoshidan
Copy link
Contributor Author

yoshidan commented Mar 14, 2025

@bluele @siburu The following commit fix it.
3f16df2

bluele
bluele approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshidan Sorry for the late review. LGTM👍

@yoshidan yoshidan merged commit b83c842 into main Mar 14, 2025
1 check passed
@yoshidan yoshidan deleted the feature/move_account_verify branch March 14, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3100 3100 3100 left review comments

@siburu siburu siburu approved these changes

@bluele bluele bluele approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yoshidan @bluele @siburu @3100