Fix for audit #97
Merged
Fix for audit #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR addresses audit feedback by improving documentation accuracy and adding version information for the Protobuf compiler.
Changes:
- Updated the method documentation for
verify_target_attestationto clarify that the parent parameter doesn't need to be the direct predecessor block, reflecting behavior changes from the Fermi hard fork - Added Protobuf version 33.0 to the proto-compiler README for better reproducibility
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| proto-compiler/README.md | Adds Protobuf version information (33.0) for documentation |
| light-client/src/header/eth_header.rs | Improves accuracy of verify_target_attestation method documentation to reflect that parent blocks can be skipped due to Fermi hard fork |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: yoshidan <naohiro.y@gmail.com>
yoshidan
force-pushed
the
feature/fix_audit
branch
from
757c8f6 to
3b5386f
Compare
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify_target_attestation.