follow up relayer update about parallelizing chain prove #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 19, 2025 06:14
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
There was a problem hiding this comment.
Pull Request Overview
Follow-up update introduces debug relayer modules and test scenarios (including a new service test) to exercise parallelized chain prove logic with optional "fakelost" (debug) behavior.
- Adds debug chain and prover modules to the relayer binary and updates relayer dependency.
- Wraps existing mock prover configs with a debug prover layer in test JSON configs and enables fakelost-related env vars in test scripts.
- Adds utility script, new test (test-service), and supporting Makefile / docker-compose adjustments.
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/chains/ethereum/Makefile | Adds clean target for Ethereum test artifacts. |
| tests/cases/tm2eth/scripts/utils | New helper functions for querying and sending packets. |
| tests/cases/tm2eth/scripts/test-service | New end-to-end service mode test with fakelost debug env support. |
| tests/cases/tm2eth/scripts/test-mockapp-packet-relay | Reuses utility function for Ethereum packet sending and adds fakelost env handling. |
| tests/cases/tm2eth/scripts/test-ics20-packet-relay | Adds fakelost debug env handling. |
| tests/cases/tm2eth/scripts/test-channel-upgrade | Adds fakelost debug env handling. |
| tests/cases/tm2eth/scripts/handshake | Adds fakelost debug env handling. |
| tests/cases/tm2eth/configs/template/ibc-1.template.json | Wraps mock prover with debug prover configuration. |
| tests/cases/tm2eth/configs/demo/ibc-0.json | Wraps mock prover with debug prover configuration. |
| tests/cases/tm2eth/Makefile | Exports USE_FAKELOST default and adds new test script to sequence. |
| tests/cases/docker-compose-test.yaml | Extends channel upgrade timeout for mock Tendermint services. |
| relayer/main.go | Registers debug chain and prover modules. |
| go.mod | Updates yui-relayer dependency via replace to newer pseudo-version. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
siburu
reviewed
Sep 25, 2025
siburu
reviewed
Sep 25, 2025
siburu
reviewed
Sep 25, 2025
siburu
reviewed
Sep 25, 2025
added 6 commits
September 29, 2025 02:33
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
siburu
reviewed
Dec 11, 2025
| environment: | ||
| USE_MOCK_CLIENT: 1 | ||
| IBC_CHANNEL_UPGRADE_TIMEOUT: 30000000000 | ||
| IBC_CHANNEL_UPGRADE_TIMEOUT: 480000000000 #480 sec |
Contributor
There was a problem hiding this comment.
@dai1975 I think this timeout could be set shorter. What would be a appropriate value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update relayer version and add fakelost test