Skip to content

Default event:reindex_touched_dois to run task for events updated yesterday#84

Merged
codycooperross merged 2 commits intomainfrom
task-tweak
Mar 18, 2026
Merged

Default event:reindex_touched_dois to run task for events updated yesterday#84
codycooperross merged 2 commits intomainfrom
task-tweak

Conversation

@codycooperross
Copy link
Contributor

@codycooperross codycooperross commented Mar 13, 2026

Purpose

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Summary by CodeRabbit

  • Refactor
    • Made date parameters optional for the reindexing task: START_DATE now defaults to yesterday when omitted, and END_DATE defaults to START_DATE. Removed the hard error for a missing START_DATE while keeping validation that END_DATE cannot be before START_DATE. Updated task help text with an example invocation; invocation path remains unchanged.

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 151bfd19-6315-4bf6-994c-a760c49e2d10

📥 Commits

Reviewing files that changed from the base of the PR and between ef9e67a and fa8175f.

📒 Files selected for processing (1)
  • lib/tasks/event.rake
🚧 Files skipped from review as they are similar to previous changes (1)
  • lib/tasks/event.rake

📝 Walkthrough

Walkthrough

The reindex_touched_dois Rake task in lib/tasks/event.rake now treats START_DATE as optional (defaults to yesterday) and END_DATE as optional (defaults to START_DATE). Task description updated, example usage added, and the explicit error for missing START_DATE removed; END_DATE >= START_DATE validation kept.

Changes

Cohort / File(s) Summary
Rake Task Date Handling
lib/tasks/event.rake
Made START_DATE optional (defaults to yesterday) and END_DATE optional (defaults to START_DATE). Reworded task description, added example usage, removed explicit missing-START_DATE error, retained END_DATE >= START_DATE validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: making START_DATE optional and defaulting to yesterday for the event:reindex_touched_dois task.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task-tweak
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/tasks/event.rake`:
- Line 39: The long comment on the task description line (the comment
referencing START_DATE/END_DATE and the example command for
event:reindex_touched_dois) exceeds RuboCop's Layout/LineLength; break this
single long comment into multiple shorter comment lines (e.g. split the sentence
and place the example command on its own commented line) so each line is under
the max length while preserving the exact information about START_DATE
defaulting to yesterday, END_DATE defaulting to START_DATE, and the example
command `START_DATE=2026-03-01 END_DATE=2026-03-02 bundle exec rake
event:reindex_touched_dois`.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c0d6b2fc-a251-4c14-bc87-152130fc63f3

📥 Commits

Reviewing files that changed from the base of the PR and between 4ae766e and ef9e67a.

📒 Files selected for processing (1)
  • lib/tasks/event.rake

@codycooperross codycooperross merged commit 846a1b2 into main Mar 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants