-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade: Rails 7.2 → 8.1 & Ruby 3.2.9 → 4.0.1 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kaysiz
wants to merge
10
commits into
main
Choose a base branch
from
ks-rails-8-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c891909
upgrade ruby 4 and rails 8
kaysiz d3c3249
remove git gem and restructure how we get version, and add security c…
kaysiz 1ff68d8
update ruby version
kaysiz 76cb601
upgrade rails and ruby
kaysiz 4fcab74
upgrade and pin test group gems
kaysiz e7d3e1a
update simplecov config
kaysiz b705620
fix rubocop issues
kaysiz ba3d362
Add addressable gem
kaysiz da02b32
address feedback
kaysiz 7f95854
separate security check from parallel ci
kaysiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.2.10 | ||
| ruby-4.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,48 @@ | ||
| source "https://rubygems.org" | ||
|
|
||
| ruby "3.2.10" | ||
| ruby "4.0.1" | ||
|
|
||
| gem "rails", "~> 7.2", ">= 7.2.3" | ||
| gem "bootsnap", require: false | ||
| gem "rack-cors" | ||
| gem "shoryuken", "~> 7.0" | ||
| gem "aws-sdk-sqs", "~> 1.3" | ||
| gem "lograge", "~> 0.11.2" | ||
| gem "logstash-event", "~> 1.2", ">= 1.2.02" | ||
| gem "logstash-logger", "~> 0.26.1" | ||
| gem "mysql2", "~> 0.5.3" | ||
| gem "dotenv" | ||
| gem "sentry-ruby" | ||
| gem "sentry-rails" | ||
| gem "elasticsearch", "~> 7.17", ">= 7.17.10" | ||
| gem "elasticsearch-model", "~> 7.2.1", ">= 7.2.1", require: "elasticsearch/model" | ||
| gem "elasticsearch-rails", "~> 7.2.1", ">= 7.2.1" | ||
| gem "elasticsearch-transport", "~> 7.17", ">= 7.17.10" | ||
| gem "git", "~> 1.5" | ||
| gem "faraday", "~> 2.9" | ||
| gem "faraday_middleware-aws-sigv4", "~> 0.3.0" | ||
| gem "faraday-excon" | ||
| gem "rails", "~> 8.1", ">= 8.1.2.1" | ||
| gem "addressable", "~> 2.8", ">= 2.8.9" | ||
| gem "bootsnap", "~> 1.23", require: false | ||
| gem "rack-cors", "~> 3.0" | ||
| gem "shoryuken", "~> 7.0", ">= 7.0.1" | ||
| gem "aws-sdk-sqs", "~> 1.112" | ||
| gem "lograge", "~> 0.14.0" | ||
| gem "logstash-logger", "~> 1.0" | ||
| gem "mysql2", "~> 0.5.7" | ||
| gem "dotenv", "~> 3.2" | ||
| gem "sentry-ruby", "~> 6.5" | ||
| gem "sentry-rails", "~> 6.5" | ||
| gem "elasticsearch", "~> 8.19", ">= 8.19.3" | ||
| gem "elasticsearch-model", "~> 8.0", ">= 8.0.1", require: "elasticsearch/model" | ||
| gem "elasticsearch-rails", "~> 8.0", ">= 8.0.1" | ||
| gem "elastic-transport", "~> 8.0", ">= 8.0.1" | ||
| gem "faraday", "~> 2.14", ">= 2.14.1" | ||
| gem "faraday_middleware-aws-sigv4", "~> 1.0", ">= 1.0.1" | ||
| gem "faraday-excon", "~> 2.4" | ||
| gem "uuid", "~> 2.3", ">= 2.3.9" | ||
| gem "oj", "~> 3.16", ">= 3.16.11" | ||
|
|
||
| # This gem will allow us to write tests without the need for a database | ||
| gem "activerecord-nulldb-adapter", "~> 1.1", ">= 1.1.1" | ||
| gem "oj", "~> 3.16", ">= 3.16.16" | ||
| gem "parallel", "~> 1.27" | ||
|
|
||
| group :development, :test do | ||
| gem "debug", platforms: [:mri, :windows] | ||
| gem "rubocop", require: false | ||
| gem "rubocop-shopify", require: false | ||
| gem "rubocop-rspec", require: false | ||
| gem "rubocop-performance", require: false | ||
| gem "rubocop-factory_bot", require: false | ||
| gem "rubocop-rails", require: false | ||
| gem "rubocop-rspec_rails", require: false | ||
| gem "factory_bot_rails" | ||
| gem "bundler-audit", require: false | ||
| gem "brakeman", require: false | ||
| gem "rspec-rails", "~> 7.0.0" | ||
| gem "debug", "~> 1.11", ">= 1.11.1", platforms: [:mri, :windows] | ||
| gem "rubocop", "~> 1.86", require: false | ||
| gem "rubocop-shopify", "~> 2.18", require: false | ||
| gem "rubocop-rspec", "~> 3.9", require: false | ||
| gem "rubocop-performance", "~> 1.26", ">= 1.26.1", require: false | ||
| gem "rubocop-factory_bot", "~> 2.28", require: false | ||
| gem "rubocop-rails", "~> 2.34", ">= 2.34.3", require: false | ||
| gem "rubocop-rspec_rails", "~> 2.32", require: false | ||
| gem "factory_bot_rails", "~> 6.5", ">= 6.5.1" | ||
| gem "bundler-audit", "~> 0.9.3", require: false | ||
| gem "brakeman", "~> 8.0", ">= 8.0.4", require: false | ||
| gem "rspec-rails", "~> 8.0", ">= 8.0.4" | ||
| end | ||
|
|
||
| group :test do | ||
| gem "simplecov", require: false | ||
| gem "shoulda-matchers" | ||
| gem "coveralls_reborn", require: false | ||
| gem "simplecov", "~> 0.22.0", require: false | ||
| gem "shoulda-matchers", "~> 7.0", ">= 7.0.1" | ||
| gem "coveralls_reborn", "~> 0.29.0", require: false | ||
| gem "activerecord-nulldb-adapter", "~> 1.2", ">= 1.2.2" # This gem will allow us to write tests without the need for a database | ||
| end |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.