fix(mcp): graceful error handling nei tool read-only#28
Merged
Conversation
…dling Ogni tool MCP ora cattura requests.HTTPError e restituisce una stringa di errore contestuale invece di crashare. Aggiunti 3 test per i casi 403, 404, 500 su session_bootstrap, workspace_triage e topic_index.
Gabrymi93
force-pushed
the
fix-mcp-graceful-errors
branch
from
April 24, 2026 18:00
eb6426f to
fcf6d7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
I tre tool MCP read-only (
session_bootstrap,workspace_triage,topic_index) ora catturanorequests.HTTPErrore restituiscono una stringa di errore contestuale invece di crashare.Problema
_fetchusaraise_for_status()— quando GitHub è down, rate-limited, o il branch/context non esiste, l'MCP tool sollevava un'eccezione non gestita, mandando in crash il server o restituendo un internal error al client.Soluzione
Wrap in
try/except requests.HTTPErrorin ogni tool, con messaggio che include il nome del tool e il codice HTTP:refresh_contextera già protetto (gestisce esplicitamente il codice 204).Test
3 nuovi test:
test_session_bootstrap_http_error— 403test_workspace_triage_http_error— 404test_topic_index_http_error— 50057 test passano, coverage
mcp_server.py97%.Verifica
pytest -qverde (57 passed)