Skip to content

Conversation

@godofdream
Copy link

while trying to import all my priviledges I stumbled about missing allowed actions.

@anmoel
Copy link
Member

anmoel commented Jun 14, 2024

Hi @godofdream,

thanks for your contribution.
please change also the tests, so we can be sure that the privileges are possible.

kind regards
André

@godofdream
Copy link
Author

@CodiumAI-Agent /review

@QodoAI-Agent
Copy link

QodoAI-Agent commented Jun 17, 2024

PR Reviewer Guide 🔍

(Review updated until commit 2e68470)

⏱️ Estimated effort to review [1-5] 2
🧪 Relevant tests Yes
🔒 Security concerns No
⚡ Key issues to review Possible Bug:
The addition of the "ALL" action in various resources might be intended to represent a wildcard for all actions. However, it's important to ensure that this does not unintentionally grant more permissions than expected. It's recommended to verify the implementation logic behind handling the "ALL" action to ensure it behaves as intended without security risks.

@godofdream
Copy link
Author

@CodiumAI-Agent /review

@godofdream
Copy link
Author

@anmoel Hey I extended the tests.

@QodoAI-Agent
Copy link

Persistent review updated to latest commit 0bfb45c

@godofdream
Copy link
Author

@CodiumAI-Agent /review

@QodoAI-Agent
Copy link

Persistent review updated to latest commit 2e68470

@chris-ruecker
Copy link
Contributor

Hi @godofdream,

the acceptance tests seem to fail because of actions that do not exist. You can run the acceptance tests locally to verify your changes, please check the readme at: https://github.com/datadrivers/terraform-provider-nexus?tab=readme-ov-file#testing and resolve the issues.

Thank you for the contribution.

Regards
Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants