-
Notifications
You must be signed in to change notification settings - Fork 574
fix: native agent creation status error #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
suxinshuo
wants to merge
1
commit into
dataelement:main
Choose a base branch
from
suxinshuo:hotfix/create_agent_status
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change now forces every non-OpenClaw agent to
idleat creation time and no longer callsagent_manager.start_container, so native agents no longer transition torunningeven in environments where runtime startup is available. That breaks features that still requirerunningstatus (for example,backend/app/services/scheduler.py:43skips scheduled executions, andbackend/app/services/collaboration.py:39rejects delegation), causing newly created native agents to lose automation/collaboration behavior until status is manually changed.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, starting the native agent now also requires starting the OpenClaw container, which is unreasonable. If Docker isn't used for deployment, it will directly enter an idle state, affecting the two points mentioned above. Therefore, setting it to idle here is reasonable, at least it won't cause any further problems.

@yaojin3616 PTAL